Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-67332] Pull up Telemetry.buildComponentInformation for use in SlaveToMasterFileCallableUsage #6031

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 8, 2021

#5890 (comment)

We are getting more hits than initially expected from what appear to be long-obsolete plugin versions running on recent weeklies. This telemetry addition should help us confirm that deprecated agent-to-controller file calls are not being made by current versions of plugins.

Proposed changelog entries

  • N/A

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a potential candidate to get into .2?

CC @timja

@daniel-beck
Copy link
Member

We are getting more hits than initially expected from what appear to be long-obsolete plugin versions running on recent weeklies.

Examples:

  • xunit 2.0.2 or older (obsolete since June 2018)
  • warnings-ng 5.1.0 or older (obsolete since June 2019)

The continuously updated JEP notes them.

@jglick
Copy link
Member Author

jglick commented Dec 8, 2021

a potential candidate to get into .2?

Sure, if it would be helpful. (Though preferably a modified version of this with @Restricted(NoExternalUse.class).)

@timja
Copy link
Member

timja commented Dec 8, 2021

Also a potential candidate to get into .2?

CC @timja

sure should have a jira issue then with the label on it

@timja timja added skip-changelog Should not be shown in the changelog ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Dec 8, 2021
@daniel-beck
Copy link
Member

@jglick jglick changed the title Pull up Telemetry.buildComponentInformation for use in SlaveToMasterFileCallableUsage [JENKINS-67332] Pull up Telemetry.buildComponentInformation for use in SlaveToMasterFileCallableUsage Dec 8, 2021
@basil basil merged commit 59cc04c into jenkinsci:master Dec 9, 2021
@jglick jglick deleted the Telemetry.buildComponentInformation branch December 9, 2021 18:34
cathychan pushed a commit to cathychan/jenkins that referenced this pull request Dec 17, 2021
@daniel-beck daniel-beck mentioned this pull request Dec 17, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants