Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous modernization cleanup #6411

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Mar 28, 2022

This PR polishes several components:

  • Utilize the computer symbol in SlaveComputer
  • Use the cogwheel symbol to edit an agent, like previously.
  • Adapt the color scheme on drop downs
  • The text preview box is now less sharp
  • Single line -> multi line expanders now expand into a jenkins-input to benefit from the modernization
  • Other minor changes

Proposed changelog entries

  • Miscellaneous polishing of various components.

Proposed upgrade guidelines

N/A

Submitter checklist

  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@timja timja requested a review from a team March 28, 2022 11:09
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using a docker jenkins/core-pr-tester container. It seems to be fine, expect that some localization are not respected. I tested using the Locale plugin. I'm only mentioning this for global security configuration side panel addition.

The strings are copied from previously approved files.
@timja timja requested a review from alecharp March 29, 2022 15:35
@NotMyFault NotMyFault requested a review from timja March 30, 2022 14:02
@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Mar 30, 2022
@timja
Copy link
Member

timja commented Mar 30, 2022

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@NotMyFault
Copy link
Member Author

Is there anything that blocks a merge @timja?

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 1, 2022
@timja
Copy link
Member

timja commented Apr 1, 2022

Is there anything that blocks a merge @timja?

No I slipped up on not adding the label, no real rush though generally we just make sure the PRs are merged by Tuesday to make the weekly, the 24 hours is more a minimum than an actual time.

@timja timja merged commit d413891 into jenkinsci:master Apr 1, 2022
@NotMyFault NotMyFault deleted the feat/master/misc-modernization-cleanup branch April 1, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants