-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous modernization cleanup #6411
Miscellaneous modernization cleanup #6411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested using a docker jenkins/core-pr-tester
container. It seems to be fine, expect that some localization are not respected. I tested using the Locale plugin. I'm only mentioning this for global security configuration side panel addition.
core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
Show resolved
Hide resolved
The strings are copied from previously approved files.
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Is there anything that blocks a merge @timja? |
No I slipped up on not adding the label, no real rush though generally we just make sure the PRs are merged by Tuesday to make the weekly, the 24 hours is more a minimum than an actual time. |
This PR polishes several components:
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@jenkinsci/sig-ux
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).