jenkinsci · timja · Jul 18, 2022 · Jun 26, 2022 · Jun 26, 2022 · Jun 26, 2022
diff --git a/core/src/main/java/jenkins/model/NewViewLink.java b/core/src/main/java/jenkins/model/NewViewLink.java
diff --git a/core/src/main/resources/jenkins/model/Messages.properties b/core/src/main/resources/jenkins/model/Messages.properties
@@ -61,8 +61,6 @@ JenkinsLocationConfiguration.does_not_look_like_an_email_address=Does not look l
 Mailer.Localhost.Error=Please set a valid host name, instead of localhost
 Mailer.NotHttp.Error=The URL is invalid, please ensure you are using http:// or https:// with a valid domain.
 
-NewViewLink.NewView=New View
-
 PatternProjectNamingStrategy.DisplayName=Pattern
 PatternProjectNamingStrategy.NamePatternRequired=Name Pattern is required
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=regular expression''s syntax is invalid.

diff --git a/core/src/main/resources/jenkins/model/Messages_de.properties b/core/src/main/resources/jenkins/model/Messages_de.properties
@@ -49,8 +49,6 @@ DefaultProjectNamingStrategy.DisplayName=keine Einschränkung
 Mailer.Address.Not.Configured=Adresse nicht konfiguriert <nobody@nowhere>
 Mailer.Localhost.Error=Bitte verwenden Sie einen konkreten Hostnamen anstelle von <code> localhost </code>.
 
-NewViewLink.NewView=Ansicht anlegen
-
 PatternProjectNamingStrategy.DisplayName=Muster
 PatternProjectNamingStrategy.NamePatternRequired=Der Reguläre Ausdruck darf nicht leer sein.
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=Der Reguläre Ausdruck ist ungültig.

diff --git a/core/src/main/resources/jenkins/model/Messages_fr.properties b/core/src/main/resources/jenkins/model/Messages_fr.properties
@@ -52,5 +52,3 @@ ParameterizedJobMixIn.build_now=Lancer un build
 BlockedBecauseOfBuildInProgress.shortDescription=Le build #{0} est déjà en cours {1}
 BlockedBecauseOfBuildInProgress.ETA=\ (fin prévue à : {0})
 BuildDiscarderProperty.displayName=Supprimer les anciens builds
-
-NewViewLink.NewView=Créer une Vue
diff --git a/core/src/main/resources/jenkins/model/Messages_it.properties b/core/src/main/resources/jenkins/model/Messages_it.properties
@@ -72,7 +72,6 @@ Mailer.Address.Not.Configured=Indirizzo non ancora configurato \
 Mailer.Localhost.Error=Impostare un nome host valido anziché localhost
 Mailer.NotHttp.Error=L''URL non è valido, assicurarsi di utilizzare http:// o \
   https:// con un dominio valido.
-NewViewLink.NewView=Nuova vista
 ParameterizedJobMixIn.build_now=Compila ora
 ParameterizedJobMixIn.build_with_parameters=Compila con parametri
 PatternProjectNamingStrategy.DisplayName=Pattern

diff --git a/core/src/main/resources/jenkins/model/Messages_ja.properties b/core/src/main/resources/jenkins/model/Messages_ja.properties
@@ -52,8 +52,6 @@ CLI.safe-shutdown.shortDescription=\
 
 DefaultProjectNamingStrategy.DisplayName=デフォルト
 
-NewViewLink.NewView=新規ビュー
-
 PatternProjectNamingStrategy.DisplayName=パターン
 PatternProjectNamingStrategy.NamePatternRequired=パターンは必須です。
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=正規表現に誤りがあります。

diff --git a/core/src/main/resources/jenkins/model/Messages_ko.properties b/core/src/main/resources/jenkins/model/Messages_ko.properties
@@ -4,8 +4,6 @@ Hudson.ViewAlreadyExists="{0}" 이름의 뷰가 이미 존재합니다.
 
 CLI.restart.shortDescription=Jenkins를 안전하게 재시작
 
-NewViewLink.NewView=새로운 뷰
-
 ParameterizedJobMixIn.build_with_parameters=파라미터와 함께 빌드
 ParameterizedJobMixIn.build_now=지금 빌드
 BlockedBecauseOfBuildInProgress.shortDescription=빌드 #{0} 가 이미 진행중입니다{1}

diff --git a/core/src/main/resources/jenkins/model/Messages_pt_BR.properties b/core/src/main/resources/jenkins/model/Messages_pt_BR.properties
@@ -62,7 +62,6 @@ Mailer.NotHttp.Error=A URL é inválida, por favor se certifique que você está
   válido.
 Hudson.Computer.IncorrectNumberOfExecutors=Campo "Número de executores" incorreto. Ele precisa ser um número não \
   negativo.
-NewViewLink.NewView=Nova visão
 EnforceSlaveAgentPortAdministrativeMonitor.displayName=Impor porta TCP para o agente
 BuiltInNodeMigration.DisplayName=Nome do nó embutido e migração de rótulo
 SimpleGlobalBuildDiscarderStrategy.displayName=Descartador de construção específico

diff --git a/core/src/main/resources/jenkins/model/Messages_ru.properties b/core/src/main/resources/jenkins/model/Messages_ru.properties
@@ -55,4 +55,3 @@ PatternProjectNamingStrategy.NamePatternInvalidSyntax=Некорректное
 ParameterizedJobMixIn.build_with_parameters=Собрать с параметрами
 CLI.disable-job.shortDescription=Запретить задачу
 CLI.enable-job.shortDescription=Разрешить задачу
-NewViewLink.NewView=Новое представление
diff --git a/core/src/main/resources/jenkins/model/Messages_tr.properties b/core/src/main/resources/jenkins/model/Messages_tr.properties
@@ -30,7 +30,6 @@ Hudson.NoJavaInPath=java, PATH içerisinde değil. <a href=''{0}/configure''>JDK
 Hudson.NoName=İsim belirtilmedi
 Hudson.UnsafeChar=''{0}'' güvenli olmayan bir karakter
 Hudson.ViewName=Hepsi
-NewViewLink.NewView=Yeni Görünüm
 ParameterizedJobMixIn.build_now=Şimdi Yapılandır
 BlockedBecauseOfBuildInProgress.shortDescription=Yapılandırma #{0} zaten işlemde {1}
 BlockedBecauseOfBuildInProgress.ETA=\ (ETA: {0})

diff --git a/core/src/main/resources/jenkins/model/Messages_zh_TW.properties b/core/src/main/resources/jenkins/model/Messages_zh_TW.properties
@@ -55,8 +55,6 @@ JenkinsLocationConfiguration.does_not_look_like_an_email_address=這看起來不
 Mailer.Localhost.Error=請設定有效的主機名稱，不要用 localhost
 Mailer.NotHttp.Error=URL 無效，請確保您使用 http\:// 或 https\:// 和有效的網域名稱。
 
-NewViewLink.NewView=新增視景
-
 PatternProjectNamingStrategy.DisplayName=樣式
 PatternProjectNamingStrategy.NamePatternRequired=一定要輸入名稱樣式
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=正規表示式語法錯誤。

diff --git a/core/src/main/resources/lib/layout/tabNewItem.jelly b/core/src/main/resources/lib/layout/tabNewItem.jelly
@@ -10,7 +10,7 @@
     </st:documentation>
 
     <div class="tab">
-        <a href="${href}" class="addTab" aria-label="${attrs.title}">
+        <a href="${href}" class="addTab" aria-label="${attrs.title}" tooltip="${attrs.title}">
             <l:icon src="symbol-add" />
         </a>
     </div>

diff --git a/core/src/test/java/jenkins/model/NewViewLinkTest.java b/core/src/test/java/jenkins/model/NewViewLinkTest.java
diff --git a/test/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java b/test/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java
@@ -127,8 +127,9 @@ public void doNotAcceptNonHttpBasedRootURL_fromConfigXml() {
 
     @Test
     @Issue("SECURITY-1471")
-    public void cannotInjectJavaScriptUsingRootUrl_inNewViewLinkAction() throws Exception {
+    public void cannotInjectJavaScriptUsingRootUrl_inNewViewLink() throws Exception {
         JenkinsRule.WebClient wc = j.createWebClient();
+        j.createFreeStyleProject();
 
         settingRootURL("javascript:alert(123);//");