Remove the 'New View' sidebar link

[janfaracik]

This PR removes the 'New View' sidebar link as it's currently duplicated on the page, once in the tab bar and once in the sidebar. This simplifies the page and makes it easier to tab through.

Proposed changelog entries

• Remove the 'New View' sidebar link.

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
• New deprecations are annotated with @Deprecated(since="TODO") or @Deprecated(since="TODO", forRemoval=true) if applicable.
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[janfaracik]

I've updated the test as the 'New View' sidebar action is gone now. The updated test instead tests the 'New View' tab bar link. I've had to create a new project at the start of the test to bypass the 'Welcome to Jenkins!' screen.

[daniel-beck]

Pinging @uhafner who filed https://issues.jenkins.io/browse/JENKINS-6290

[uhafner]

I think the + button has a clear visualization right now (a tool tip wouldn't hurt though). In the old style tabs it was not clear that one can add a new view.

[uhafner]

I wonder if it would also make sense (not in this PR) to remove the edit and delete view actions in the side panel (for the active view). Maybe those can be integrated into the tab header somehow? What do you think?

[janfaracik]

I think the + button has a clear visualization right now (a tool tip wouldn't hurt though). In the old style tabs it was not clear that one can add a new view.

Agreed! I've added a tooltip to the + button :)

I wonder if it would also make sense (not in this PR) to remove the edit and delete view actions in the side panel (for the active view). Maybe those can be integrated into the tab header somehow? What do you think?

I also agree, ideally I'd like to move actions to the top app bar and use the sidebar solely for navigation.

Cheers :)

[daniel-beck]

Remember that actions removed from the sidepanel are also removed from the breadcrumbs, making them less easily accessible.

[timja]

can we run through ATH?

[timja]

ATH has passed #6703

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

Caused JENKINS-70825.