Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60866][JENKINS-71797] Remove timeline widget #6869

Merged
merged 13 commits into from Nov 5, 2023

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jul 17, 2022

See JENKINS-60866.

This removes the timeline widget without replacement. I've never found it particularly useful, and it is a problem for CSP. We probably want something different for these views, but for now, remove without replacement.

Screenshots Screenshot 2023-08-28 at 19 31 04 Screenshot 2023-08-28 at 19 31 14 Screenshot 2023-08-28 at 19 31 46

Proposed changelog entries

  • Remove build timeline widget from the build history pages of views, jobs, and agents.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck changed the title [JENKINS-60866] Remove timeline widget [JENKINS-60866][JENKINS-71797] Remove timeline widget Aug 11, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, is there anything remaining to take this out of draft?

See also discussion on the forum:
https://community.jenkins.io/t/does-anybody-find-the-build-history-timeline-useful/8491/5

@daniel-beck
Copy link
Member Author

Makes sense to me, is there anything remaining to take this out of draft?

Unsure why this was draft to begin with. I think I wanted to prevent premature merges without giving people the opportunity to weigh in, but I guess that is obsolete since about a year ago? :-)

Working on #8431 I discovered this has some leftover stuff in bom etc. that I still need to clean up.

@daniel-beck daniel-beck marked this pull request as ready for review August 28, 2023 17:27
@daniel-beck daniel-beck added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted removed This PR removes a feature or a public API labels Aug 28, 2023
@daniel-beck
Copy link
Member Author

Might even fix (or alleviate somewhat) https://issues.jenkins.io/browse/JENKINS-72138

@timja
Copy link
Member

timja commented Oct 6, 2023

Could you run this through ATH and bom please to be safe? Happy to approve after that.

@timja timja added the needs-ath-build Needs to run through the full acceptance-test-harness suite label Oct 6, 2023
daniel-beck added a commit to daniel-beck/bom that referenced this pull request Oct 17, 2023
@timja timja added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed needs-ath-build Needs to run through the full acceptance-test-harness suite labels Oct 17, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team October 17, 2023 15:52
Copy link

@rsahoo7495 rsahoo7495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkEWaite
Copy link
Contributor

+1 from me to remove the widget. That should resolve the JavaScript warning that I see in the browser console when viewing the timeline. The message in the console is:

GET https://www.example.com/jenkins/view/Controllers/__history__.html?0 404 (Not Found)
SimileAjax.History.initialize @ simile-ajax-bundle.js:921
SimileAjax.History.addListener @ simile-ajax-bundle.js:926
SimileAjax.WindowManager.initialize @ simile-ajax-bundle.js:1360
Timeline._Impl @ timeline-bundle.js:2619
Timeline.create @ timeline-bundle.js:2556
doLoad @ build-timeline-widget.js:80
load (async)
(anonymous) @ build-timeline-widget.js:109

@timja
Copy link
Member

timja commented Nov 3, 2023

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 3, 2023
@timja timja merged commit dd04e33 into jenkinsci:master Nov 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ath-successful This PR has successfully passed the full acceptance-test-harness suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback removed This PR removes a feature or a public API rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
6 participants