Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60866][JENKINS-71797] Replace timeline widget with a maintained one #8431

Closed
wants to merge 5 commits into from
Closed

[JENKINS-60866][JENKINS-71797] Replace timeline widget with a maintained one #8431

wants to merge 5 commits into from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Aug 25, 2023 •
edited

Still early WIP. Probably going to include the timeline via yarn if this is deemed viable. Alternative to #6869.

WDYT?

See JENKINS-71797.

Before

Screenshot 2023-08-25 at 17 38 48

After

Screenshot 2023-08-25 at 17 42 35

Testing done

Proposed changelog entries

  • Entry 1: Issue, human-readable text
  • […]

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@daniel-beck daniel-beck added the work-in-progress The PR is under active development, not ready to the final review label Aug 25, 2023
@daniel-beck daniel-beck changed the title [JENKINS-71797] Replace timeline widget with a maintained one [JENKINS-60866][JENKINS-71797] Replace timeline widget with a maintained one Aug 25, 2023
@NotMyFault
Copy link
Member

WDYT?

May I ask what's the motivation to use a niche framework like visjs?
I feel like using a more common framework, such as chart.js, d3, etc. is more community and maintainer friendly, given these have millions of adopters and people probably have heard or used them before already.

@daniel-beck
Copy link
Member Author

daniel-beck commented Aug 25, 2023 •
edited

May I ask what's the motivation to use a niche framework like visjs?

🤷 Google Search for timeline widget. Happy to re-do this (once) if desired, just need to know what library is acceptable to use. chart.js looks like it doesn't have what we want, and d3 seems way too low level? See e.g. how nicely this chart supports zooming.

@daniel-beck daniel-beck mentioned this pull request Aug 28, 2023
Merged
12 tasks
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Nov 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

@daniel-beck
Copy link
Member Author

Closing as #6869 was merged.

@daniel-beck daniel-beck closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unresolved-merge-conflict There is a merge conflict with the target branch. work-in-progress The PR is under active development, not ready to the final review
Projects
None yet
Milestone
No milestone
2 participants
@daniel-beck @NotMyFault