Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jenkins from 1.80 to 1.81 #6875

Merged
merged 1 commit into from Jul 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 18, 2022

Bumps jenkins from 1.80 to 1.81.

Release notes

Sourced from jenkins's releases.

1.81

馃殌 New features and improvements

馃摝 Dependency updates

Commits
  • 74784a8 [maven-release-plugin] prepare release jenkins-1.81
  • 5d273c3 Skip yarn lint in -P quick-build (#280)
  • d050057 Bump maven-project-info-reports-plugin from 3.3.0 to 3.4.0 (#279)
  • 8914989 Bump exec-maven-plugin from 3.0.0 to 3.1.0 (#278)
  • e1c8b7a Bump spotbugs-maven-plugin from 4.7.0.0 to 4.7.1.0 (#277)
  • ee449c8 Bump extra-enforcer-rules from 1.5.1 to 1.6.0 (#275)
  • 626a427 Bump maven-assembly-plugin from 3.4.0 to 3.4.1 (#276)
  • 10623e5 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jenkins](https://github.com/jenkinsci/pom) from 1.80 to 1.81.
- [Release notes](https://github.com/jenkinsci/pom/releases)
- [Changelog](https://github.com/jenkinsci/pom/blob/master/CHANGELOG-old.md)
- [Commits](jenkinsci/pom@jenkins-1.80...jenkins-1.81)

---
updated-dependencies:
- dependency-name: org.jenkins-ci:jenkins
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 18, 2022
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog labels Jul 18, 2022
@basil basil merged commit f53b97b into master Jul 19, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci-jenkins-1.81 branch July 19, 2022 15:38
@NotMyFault
Copy link
Member

Something changed between 1.80 and 1.81 that caused enforcer complaining about missing artifacts:
https://gist.githubusercontent.com/NotMyFault/7ef6255d3c211c2b8aadcb2e64544e6b/raw/661245205104db64452bef4ffb4672c303a4e7fd/gistfile1.txt

Same can be found on the default branch build https://ci.jenkins.io/job/Core/job/jenkins/job/master/3869/consoleFull

Reverting locally to 1.80 resolved the issue for me.

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jul 20, 2022

Something changed between 1.80 and 1.81 that caused enforcer complaining about missing artifacts: https://gist.githubusercontent.com/NotMyFault/7ef6255d3c211c2b8aadcb2e64544e6b/raw/661245205104db64452bef4ffb4672c303a4e7fd/gistfile1.txt

Same can be found on the default branch build https://ci.jenkins.io/job/Core/job/jenkins/job/master/3869/consoleFull

@basil noted in a Jenkins developer mailing list thread that it is a bug introduced into the maven enforcer plugin release 1.6.0.

A workaround has been described by @jglick that works for me. I added the following to the ~/.m2/settings.xml:

  <mirrors>
    <mirror>
      <id>repo.jenkins-ci.org</id>
      <url>https://repo.jenkins-ci.org/public/</url>
      <mirrorOf>*,!repo.jenkins-ci.org,!incrementals</mirrorOf>
    </mirror>
  </mirrors>

Previously I was using a different value in the mirrorOf tag.

@jglick
Copy link
Member

jglick commented Jul 20, 2022

mojohaus/extra-enforcer-rules#220 FTR.

A workaround [鈥: I added the following

To be clear, I did not consider this a workaround. Rather, if you were already defining a mirror (in my case to a corporate Nexus), you would probably already want to include ,!repo.jenkins-ci.org,!incrementals in your mirrorOf if it otherwise included *. (Otherwise your mirror would need to delegate to these repos in Jenkins Artifactory.) If you did not have some independent reason to use a mirror, you are not supposed to need one, or any ~/.m2/settings.xml at all, so this is clearly a regression (though apparently not fatal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
4 participants