-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-69341] Text and logo exceed sidepanel in "About Jenkins" view #6994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think changing the sidepanel width for all pages in Jenkins is an appropriate solution when one page in Jenkins with a completely custom layout looks slightly awkward in incremental builds only.
If the sidepanel should be made wider to accommodate a real need of wider labels, that's fine. But this isn't it.
Notably, the About page layout is broken at window widths of 970-1165 px anyway, so it's not even that that particular page's layout is fine otherwise.
@daniel-beck Do you mean that I need an underlaying fix? |
No, I mean that this fix changes too much (every page in Jenkins) for a very narrow bug (incremental version numbers are larger than the sidepanel on the About Jenkins page). Perhaps look into whether the About Jenkins sidepanel can be set up to wrap overflowing text? |
@daniel-beck I have made some change. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the outstanding concerns!
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
Please take a moment and address the merge conflicts of your pull request. Thanks! |
See JENKINS-69341.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
if applicable.eval
to ease future introduction of Content-Security-Policy directives (see documentation on jenkins.io).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).