Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69341] Text and logo exceed sidepanel in "About Jenkins" view #6994

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

frankie139506
Copy link
Contributor

@frankie139506 frankie139506 commented Aug 15, 2022

See JENKINS-69341.

Proposed changelog entries

  • Too minor.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content-Security-Policy directives (see documentation on jenkins.io).
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Aug 15, 2022
NotMyFault
NotMyFault previously approved these changes Aug 15, 2022
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing, looks much better:

Screenshot 2022-08-15 at 10 59 35

@NotMyFault NotMyFault requested a review from a team August 15, 2022 09:03
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think changing the sidepanel width for all pages in Jenkins is an appropriate solution when one page in Jenkins with a completely custom layout looks slightly awkward in incremental builds only.

If the sidepanel should be made wider to accommodate a real need of wider labels, that's fine. But this isn't it.

Notably, the About page layout is broken at window widths of 970-1165 px anyway, so it's not even that that particular page's layout is fine otherwise.

Screenshot 2022-08-15 at 12 25 43

@frankie139506
Copy link
Contributor Author

I don't think changing the sidepanel width for all pages in Jenkins is an appropriate solution when one page in Jenkins with a completely custom layout looks slightly awkward in incremental builds only.

If the sidepanel should be made wider to accommodate a real need of wider labels, that's fine. But this isn't it.

Notably, the About page layout is broken at window widths of 970-1165 px anyway, so it's not even that that particular page's layout is fine otherwise.

@daniel-beck Do you mean that I need an underlaying fix?

@daniel-beck
Copy link
Member

Do you mean that I need an underlaying fix?

No, I mean that this fix changes too much (every page in Jenkins) for a very narrow bug (incremental version numbers are larger than the sidepanel on the About Jenkins page).

Perhaps look into whether the About Jenkins sidepanel can be set up to wrap overflowing text?

@frankie139506
Copy link
Contributor Author

frankie139506 commented Aug 15, 2022

Do you mean that I need an underlaying fix?

No, I mean that this fix changes too much (every page in Jenkins) for a very narrow bug (incremental version numbers are larger than the sidepanel on the About Jenkins page).

Perhaps look into whether the About Jenkins sidepanel can be set up to wrap overflowing text?

@daniel-beck I have made some change. Please take a look.

@daniel-beck
Copy link
Member

Looks reasonable now (screenshot with patched DOM):
Screenshot 2022-08-15 at 16 14 39
Screenshot 2022-08-15 at 16 14 26

@frankie139506
Copy link
Contributor Author

Looks reasonable now (screenshot with patched DOM): Screenshot 2022-08-15 at 16 14 39 Screenshot 2022-08-15 at 16 14 26

Thanks. If have any problem plz tell me.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the outstanding concerns!


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 15, 2022
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 17, 2022
@github-actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 17, 2022
@timja timja merged commit 44d0496 into jenkinsci:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants