Take subtasks into account when deciding to provision new nodes #742
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
core » jenkins_main_trunk #786 FAILURE |
|
Build failure reported above is not related to code changes. |
kohsuke
added a commit
that referenced
this pull request
Apr 19, 2014
Queue length has to count individual SubTask, so that heavy weight jobs correctly provision required number of slaves through Cloud.
|
My sincere apologies for a long delay, but I finally merged it toward 1.561. |
laurence-h
added a commit
to laurence-h/jenkins
that referenced
this pull request
Jul 21, 2014
|
This change modifies the behaviour of countBuildableItemsFor(Label l) such that when label is null is counts EVERYTHING. UnlabeledLoadStatistics uses null to track the number of "free roam" jobs. This could have unintended consequences of NodeProvisioner starting slaves for jobs that won't use them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is about jobs that span multiple nodes, for distributed testing. With this purpose I extended heavy-job-plugin and installed jclouds-plugin to be able to spin up new slaves as needed.
The only problem is that Jenkins doesn't take subtasks into account when checking if there's a need to spin up new slaves. So when I have a build with 2 subtasks in the queue and 1 available executor, nothing happens as the job can't start and Jenkins doesn't see that there's a need for an additional executor.
I'm proposing to take subtasks into account. Per my understanding of the code it shouldn't have any downsides. The modified version is working well for me currently.