Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wipe Out Workspace label #748

Closed
wants to merge 3 commits into from
Closed

Improve Wipe Out Workspace label #748

wants to merge 3 commits into from

Conversation

mpailloncy
Copy link
Member

A small precision in the label "Wipe Out Workspace".
I'm sorry but I'm not able to improve this label in all languages.

@cloudbees-pull-request-builder

core » jenkins_main_trunk #805 UNSTABLE
Looks like there's a problem with this pull request

@mpailloncy
Copy link
Member Author

This pull request contains only label value changes on sidepanel*.properties files.
Why the build is unstable ?
Looks like a problem with "Publish JUnit test result report"

@jglick
Copy link
Member

jglick commented Apr 4, 2013

Apparently AbstractProjectTest was hardcoding the English label. It should be fixed to load the message from sidepanel.properties instead. (Note that there are two places where it is using this text; one is expected to fail, but in your branch is failing for the wrong reason.)

@mpailloncy
Copy link
Member Author

Thanks. I don't found any example to load the label in jenkins-test-harness.
Is there an existing way to load it properly ?

@jglick
Copy link
Member

jglick commented Apr 9, 2013

Probably just ResourceBundle.getBundle would suffice. Do not recall having ever had to do this.

@cloudbees-pull-request-builder

core » jenkins_main_trunk #830 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

core » jenkins_main_trunk #831 FAILURE
Looks like there's a problem with this pull request

@mpailloncy mpailloncy closed this Apr 14, 2013
@mpailloncy mpailloncy deleted the JENKINS-17416 branch April 14, 2013 18:17
@jglick
Copy link
Member

jglick commented Apr 16, 2013

Any particular reason this was closed?

@mpailloncy
Copy link
Member Author

Sorry, I thought I had made ​​a mistake with a merge so I decided to create another pull request but I could continue with this one ...
Thank you for your help again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants