Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Polish translations for Jenkins plugin manager #7593

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add Polish translations for Jenkins plugin manager #7593

merged 2 commits into from
Jan 23, 2023

Conversation

damianszczepanik
Copy link
Member

@damianszczepanik damianszczepanik commented Jan 18, 2023 •
edited by gitpod-io bot

Testing done

Tested locally on version 2.385

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/core-pr-reviewers

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

basil
basil previously approved these changes Jan 19, 2023
View reviewed changes
@damianszczepanik
Copy link
Member Author

Should be fine now. I guess changes were rollback after operation "branch update" on github

basil
basil approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left some optional cleanup suggestions for your consideration.

core/src/main/resources/hudson/PluginManager/advanced_pl.properties
@@ -20,6 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
Advanced\ Settings=Ustawienia zaawansowane
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/resources/hudson/PluginManager/advanced.jelly no longer contains an "Advanced Settings" with a capital S after #6783, so this line can be deleted:

Suggested change
Advanced\ Settings=Ustawienia zaawansowane

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this is technical debt of mentioned PR and should be fixed as follow-up of them. Not by removing Polish translation but removing items from all localization.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. For this reason, these suggestions were merely optional.

core/src/main/resources/hudson/PluginManager/available_pl.properties
@@ -20,11 +20,14 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
Available\ Plugins=Dostępne wtyczki
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/resources/hudson/PluginManager/available.jelly no longer contains an "Available Plugins" string with a capital P, so this line can be deleted:

Suggested change
Available\ Plugins=Dostępne wtyczki

core/src/main/resources/hudson/PluginManager/installed_pl.properties
@@ -20,7 +20,10 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
Installed\ Plugins=Zainstalowane wtyczki
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/resources/hudson/PluginManager/installed.jelly no longer contains an "Installed Plugins" string with a capital I, so this line can be deleted:

Suggested change
Installed\ Plugins=Zainstalowane wtyczki

core/src/main/resources/hudson/PluginManager/table_pl.properties
Check\ to\ install\ the\ plugin=Zaznacz aby zainstalować wtyczkę
Click\ this\ heading\ to\ sort\ by\ category=Kliknij w nagłówek by posortować po kategorii
Click\ this\ heading\ to\ sort\ by\ category=Kliknij nagłówek, by posortować po kategorii
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key has been deleted since #4534:

Suggested change
Click\ this\ heading\ to\ sort\ by\ category=Kliknij nagłówek, by posortować po kategorii

timja
timja approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 22, 2023
NotMyFault
NotMyFault approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault merged commit aa3e9f5 into jenkinsci:master Jan 23, 2023
@damianszczepanik damianszczepanik deleted the translation-pl_plugins branch January 24, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
4 participants
@damianszczepanik @basil @NotMyFault @timja