Bump stapler.version from 1756.vec9071748061 to 1766.v4e428020d8a_f #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps `stapler.version` from 1756.vec9071748061 to 1766.v4e428020d8a_f. Updates `stapler` from 1756.vec9071748061 to 1766.v4e428020d8a_f - [Release notes](https://github.com/jenkinsci/stapler/releases) - [Changelog](https://github.com/jenkinsci/stapler/blob/master/CHANGELOG.md) - [Commits](https://github.com/jenkinsci/stapler/commits) Updates `stapler-groovy` from 1756.vec9071748061 to 1766.v4e428020d8a_f - [Release notes](https://github.com/jenkinsci/stapler/releases) - [Changelog](https://github.com/jenkinsci/stapler/blob/master/CHANGELOG.md) - [Commits](https://github.com/jenkinsci/stapler/commits) --- updated-dependencies: - dependency-name: org.kohsuke.stapler:stapler dependency-type: direct:production - dependency-name: org.kohsuke.stapler:stapler-groovy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
basil
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Trivial rebuild of a Jelly tag library for future compatibility with Maven 4.x. Tested locally by successfully building a plugin with Maven 4.x and these changes.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!
basil
added
ready-for-merge
NotMyFault
approved these changes
Jan 24, 2023
NotMyFault
deleted the
dependabot/maven/stapler.version-1766.v4e428020d8a_f
branch
jglick
reviewed
Jan 31, 2023
Comment on lines
-352
to
-355
| <exclusion> | ||
| <groupId>org.jvnet.hudson</groupId> | ||
| <artifactId>commons-jelly</artifactId> | ||
| </exclusion> |
There was a problem hiding this comment.
Under certain circumstances involving unusual parent POMs or BOMs, a plugin with a 2.389+ dep may encounter a test failure
java.lang.NoSuchMethodError: 'void org.kohsuke.stapler.jelly.CustomJellyContext$CustomXMLParser.setEscapeByDefault(boolean)'
at org.kohsuke.stapler.jelly.CustomJellyContext$CustomXMLParser.<init>(CustomJellyContext.java:131)
at org.kohsuke.stapler.jelly.CustomJellyContext.createXMLParser(CustomJellyContext.java:97)
at org.apache.commons.jelly.JellyContext.getXMLParser(JellyContext.java:556)
at org.apache.commons.jelly.JellyContext.compileScript(JellyContext.java:516)
at org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyCheck.runTest(JellyTestSuiteBuilder.java:102)
One fix is to add to the POM
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>jenkins-bom</artifactId>
<version>${jenkins-bom.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>reinforcing what plugin-pom normally does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
stapler.versionfrom 1756.vec9071748061 to 1766.v4e428020d8a_f.Updates
staplerfrom 1756.vec9071748061 to 1766.v4e428020d8a_fRelease notes
Sourced from stapler's releases.
Commits
Updates
stapler-groovyfrom 1756.vec9071748061 to 1766.v4e428020d8a_fRelease notes
Sourced from stapler-groovy's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)