Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor footer appearance tweaks #7989

Merged
merged 6 commits into from May 24, 2023
Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented May 12, 2023

Minor footer tweaks to bring it more inline with the ongoing design work.

  • The links now uses the .jenkins-button classes, giving them better focus states and larger hitboxes
  • The version number is clickable, offering helpful links to About Jenkins, Get involved, and the Jenkins website
  • The footer hides on mobile now
image image

Testing done

  • Footer works as before
  • Version dropdown works

Proposed changelog entries

  • Minor footer appearance tweaks

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 13, 2023
@NotMyFault NotMyFault requested a review from a team May 13, 2023 08:47
@timja
Copy link
Member

timja commented May 13, 2023

cc @imonteroperez @Vlatombe in case this impacts your product.

@NotMyFault NotMyFault added the web-ui The PR includes WebUI changes which may need special expertise label May 14, 2023
Comment on lines 236 to 241
<a class="jenkins-dropdown__item" href="${rootURL}/manage/about">
<div class="jenkins-dropdown__item__icon">
<l:icon src="symbol-jenkins" />
</div>
${%About Jenkins}
</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should probably be hidden, in case the user lacks Overall/Administer or Overall/SystemRead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually manage or system read

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what ci.j reported 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, let me know if that's the right permission 👍

@NotMyFault
Copy link
Member

Screenshot 2023-05-16 at 22 26 10

The simple-theme plugin might need an update too.

@timja
Copy link
Member

timja commented May 16, 2023

Screenshot 2023-05-16 at 22 26 10

The simple-theme plugin might need an update too.

The simple theme plugin doesn't do that as far as I know. it will be a third party theme that is not maintained from what I can see. I wouldn't worry about it.

@NotMyFault NotMyFault requested a review from timja May 22, 2023 12:07
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 22, 2023
@timja timja merged commit 4931a1f into jenkinsci:master May 24, 2023
16 checks passed
@timja timja mentioned this pull request May 24, 2023
8 tasks
@timja timja deleted the restyle-footer branch May 24, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
3 participants