Avoid scrollbar in dropdown popups (page footer, log recorder)

[zbynek]

Adds a wrapping <div> to have consistent paddingwith other dropdowns (e.g. the ones in sidebar) -- that avoids extra scrollbar when a separator is present. The diff makes more sense without whitespace changes.

Before:

After:

Footer popup introduced in this PR: #7989

Testing done

Screenshot above.

Proposed changelog entries

Avoid scrollbar in the version popup (page footer)

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

   The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Explanation as to why this change has no tests: visual improvement only

   Explanation as to why this change has no tests: visual improvement only
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

Desired reviewers

@janfaracik

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title

Beta Give feedback Tasklist Maintainer checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.

   There are at least two (2) approvals for the pull request and no outstanding requests for change.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

   Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

   Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Proper changelog labels are set so that the changelog can be generated automatically.

   Proper changelog labels are set so that the changelog can be generated automatically.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

   If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

   If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Maintainer checklist

[zbynek]

Obviously it's OK to not have this in the changelog as it doesn't affect functionality, I filled the "proposed changelog" entry just in case.

[mawinter69]

The same problem can be seen in the menu of log recorders:

I think the root cause is that the jenkins-dropdown__separator has a negative margin for left and right. When setting the margin to 0 the problem disappears.
But maybe there was a reason for that margin value. If so then the logrecorder index.jelly should be fixed as well

[mawinter69]

I think the reason for the negative margin is to extend the separator to the edges when it is wrapped in a <div class="jenkins-dropdown">. The div adds some padding so that highlighted rows (hovering with the mouse over a row) have some gap. So the div should be added to the log recorder as well

[zbynek]

@mawinter69 thanks, I changed the code to use the same wrapping div in all usages of overflowButton, even those without separator, to have consistent look. My conclusion was the same as yours -- the negative margin compensates for the outer div padding.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!