Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace disconnect and system info symbols for agents #8015

Merged
merged 2 commits into from May 20, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented May 17, 2023

The symbol to disconnect was the same as that to delete the agent. Add a new symbol that better fits for disconnecting (There is no fitting icon at ionicons, so this is one from tabler-icons that I modified to have a bigger viewport).
The symbol for System Information was still on old colored svg. Replace this with information-circle from ionicons

After:
image

Testing done

Added an inbound agent from a Jenkins build started with this change and confirmed that the new icons were displayed as expected in Google Chrome, Microsoft Edge, and Mozilla Firefox.

No test automation because we don't automate testing of icon changes.

Proposed changelog entries

  • Replace disconnect and system info symbols for agents.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

The symbol to disconnect was the same as that to delete the agent. Add a
new symbol that better fits for disconnecting (There is no fitting icon
at ionicons, so this is one from tabler-icons that I modified to have a
bigger viewport).
The symbol for System Information was still on old colored svg. Replace
this with information-circle from ionicons
@mawinter69 mawinter69 changed the title Modernize disconnect and system info symbols for agents Replace disconnect and system info symbols for agents May 17, 2023
@MarkEWaite MarkEWaite added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels May 18, 2023
@MarkEWaite MarkEWaite self-assigned this May 18, 2023
@MarkEWaite
Copy link
Contributor

Thanks for the pull request @mawinter69 ! I've updated the description with the testing that I performed.

It helps the review process very much if the submitter completes the "Testing done" section to indicate the testing that they have performed. It also helps the review process if the submitter marks the submitter checklist items as "completed" by replacing the "[ ]" text at the start of the checklist item with "[x]". Thanks again

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!


/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 18, 2023
@NotMyFault NotMyFault merged commit a74425c into jenkinsci:master May 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
3 participants