Move the 'Update' and 'Install' buttons to the app bar #8025

janfaracik · 2023-05-21T00:26:55Z

Screen.Recording.2023-05-21.at.01.25.34.mov

This PR removes the bottom app bar from the Plugins pages, moving the final control to the top app bar. This increases the available screen real estate for updates. The 'Update' and 'Install' buttons will now be disabled unless a plugin is checked, whereas previously you could click it and it would do nothing.

Testing done

Plugins install/update as before
The 'Update' and 'Install' buttons enable/disable depending on if an update is checked

Proposed changelog entries

Move the 'Update' and 'Install' buttons to the app bar.

Proposed upgrade guidelines

N/A

Submitter checklist

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
- Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

StefanSpieker

I really like this, I'm just not sure if the download and install directly functionally is still needed for updates. In the install tab it is still present?

StefanSpieker · 2023-05-21T09:09:48Z

core/src/main/resources/hudson/PluginManager/updates.jelly

-          <div class="bottom-sticker-inner">
-            <l:isAdmin>
-              <j:if test="${!empty(list)}">
-                <f:submit value="${%Download now and install after restart}"/>


Is this functionally removed?

mawinter69 · 2023-05-21T12:15:48Z

The change only affects the plugin updates page
What about the available plugins page? It would be inconsistent to have the buttons there still at the bottom

janfaracik · 2023-05-22T15:52:32Z

The change only affects the plugin updates page
What about the available plugins page? It would be inconsistent to have the buttons there still at the bottom

Happy to make that change as part of this PR or a quick follow up PR. Any thoughts?

timja · 2023-05-22T21:05:01Z

The change only affects the plugin updates page
What about the available plugins page? It would be inconsistent to have the buttons there still at the bottom

Happy to make that change as part of this PR or a quick follow up PR. Any thoughts?

the PR is quite small unless updating that will change a lot I think better to do the plugin manager as a whole

commit abd50ba Merge: d828392 31bb443 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun May 21 01:35:23 2023 +0100 Merge branch 'restyle-footer' of https://github.com/janfaracik/jenkins into restyle-footer commit d828392 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun May 21 01:34:46 2023 +0100 Require SYSTEM_READ to show About Jenkins option commit 9c79f30 Merge: 3007eae a74425c Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun May 21 01:34:34 2023 +0100 Merge branch 'master' into restyle-footer commit 31bb443 Merge: 3007eae a74425c Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun May 21 01:31:51 2023 +0100 Merge branch 'master' into restyle-footer commit 3007eae Author: Alexander Brandes <mc.cache@web.de> Date: Sat May 13 10:46:42 2023 +0200 Fix linting commit 66f7d3d Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri May 12 20:15:05 2023 +0100 Init

github-actions · 2023-06-07T20:24:22Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

janfaracik · 2023-06-07T20:28:23Z

I've updated it to include the buttons -

It's a dropdown button (due to a lack of space on smaller screens). Happy to change it into a split button if people prefer.

mawinter69 · 2023-06-07T21:32:10Z

I guess the majority of users select Install without restart so from that point of view a split button might be better.

janfaracik · 2023-06-10T19:11:12Z

I guess the majority of users select Install without restart so from that point of view a split button might be better.

Updated to be a split button. Thanks for the feedback :)

StefanSpieker · 2023-06-11T08:35:01Z

That looks really nice, but the CI complains about prettier:

[2023-06-10T19:22:42.471Z] [INFO] Running 'yarn lint:ci' in /home/jenkins/agent/workspace/Core_jenkins_PR-8025/war
[2023-06-10T19:22:47.533Z] [INFO] Checking formatting...
[2023-06-10T19:22:53.261Z] [INFO] [warn] src/main/js/plugin-manager-ui.js
[2023-06-10T19:22:58.008Z] [INFO] [warn] Code style issues found in the above file. Forgot to run Prettier?

jenkinsci/jenkins#8025

NotMyFault · 2023-06-16T07:54:30Z

I guess the majority of users select Install without restart so from that point of view a split button might be better.

Updated to be a split button. Thanks for the feedback :)

Clicking on the button does nothing for me.

timja · 2023-06-16T07:55:33Z

Same I was just testing it and the button appears to be broken. (The updates button works and looks great)

timja · 2023-06-18T21:47:11Z

(re-tested and looks great, waiting on ATH)

yaroslavafenkin

Looks fine security wise

NotMyFault

Thanks!

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

jtnord · 2023-07-21T11:00:34Z

core/src/main/resources/hudson/PluginManager/available.jelly

+            <div class="jenkins-split-button">
+              <button id="button-install" form="form" type="submit" name="dynamicLoad" class="jenkins-button jenkins-button--primary">
+                <div class="jenkins-dropdown__item__icon">
+                  <l:icon src="symbol-download" />


using download icon to me is confusing as I (the user) am not downloading anything to my machine.
Rather Jenkins is installing - which is normally an arrow pointing right or the like.

janfaracik and others added 3 commits May 21, 2023 01:22

Init

6d243e9

Update _table.js

9408f20

Fix linting

2508db5

NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels May 21, 2023

StefanSpieker reviewed May 21, 2023

View reviewed changes

janfaracik added 2 commits May 23, 2023 09:28

Add install overflow button

860f605

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 7, 2023

Merge branch 'master' into plugins-update-move-to-app-bar

5ac0701

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 7, 2023

janfaracik added 2 commits June 10, 2023 19:59

Merge branch 'master' into plugins-update-move-to-app-bar

e5b0f1a

Use a split button instead

9be6120

janfaracik changed the title ~~Move the 'Update' button to the app bar~~ Move the 'Update' and 'Install' buttons to the app bar Jun 10, 2023

Merge branch 'master' into plugins-update-move-to-app-bar

160523a

yarn lint:fix

b958185

timja requested a review from a team June 16, 2023 07:34

timja added a commit to jenkinsci/acceptance-test-harness that referenced this pull request Jun 16, 2023

Test plugin manager app bar

0791235

jenkinsci/jenkins#8025

timja mentioned this pull request Jun 16, 2023

Plugin manager app bar forward compatibility jenkinsci/acceptance-test-harness#1230

Merged

Update available.jelly

11b60b1

Merge branch 'master' into plugins-update-move-to-app-bar

30f88bc

NotMyFault requested a review from a team June 26, 2023 15:57

NotMyFault added the needs-security-review Awaiting review by a security team member label Jun 26, 2023

yaroslavafenkin approved these changes Jun 27, 2023

View reviewed changes

yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Jun 27, 2023

NotMyFault added the ath-fail The acceptance-test-harness suite needs a forward-compatible change label Jun 30, 2023

Merge branch 'master' into plugins-update-move-to-app-bar

b1fb1e2

timja mentioned this pull request Jul 5, 2023

Test plugin manager app bar jenkinsci/acceptance-test-harness#1274

Closed

NotMyFault added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed ath-fail The acceptance-test-harness suite needs a forward-compatible change labels Jul 7, 2023

NotMyFault approved these changes Jul 7, 2023

View reviewed changes

NotMyFault requested a review from a team July 7, 2023 18:08

timja approved these changes Jul 7, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 7, 2023

NotMyFault merged commit fbf1e27 into jenkinsci:master Jul 10, 2023
16 checks passed

janfaracik deleted the plugins-update-move-to-app-bar branch July 10, 2023 10:31

timja mentioned this pull request Jul 21, 2023

Plugin installing is flakey jenkinsci/acceptance-test-harness#1284

Closed

jtnord reviewed Jul 21, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move the 'Update' and 'Install' buttons to the app bar #8025

Move the 'Update' and 'Install' buttons to the app bar #8025

janfaracik commented May 21, 2023 •

edited

StefanSpieker left a comment

StefanSpieker May 21, 2023

mawinter69 commented May 21, 2023

janfaracik commented May 22, 2023 •

edited

timja commented May 22, 2023

github-actions bot commented Jun 7, 2023

janfaracik commented Jun 7, 2023

mawinter69 commented Jun 7, 2023

janfaracik commented Jun 10, 2023

StefanSpieker commented Jun 11, 2023

NotMyFault commented Jun 16, 2023

timja commented Jun 16, 2023 •

edited

timja commented Jun 18, 2023

yaroslavafenkin left a comment

NotMyFault left a comment

timja left a comment

jtnord Jul 21, 2023

Move the 'Update' and 'Install' buttons to the app bar #8025

Move the 'Update' and 'Install' buttons to the app bar #8025

Conversation

janfaracik commented May 21, 2023 • edited

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

StefanSpieker left a comment

Choose a reason for hiding this comment

StefanSpieker May 21, 2023

Choose a reason for hiding this comment

mawinter69 commented May 21, 2023

janfaracik commented May 22, 2023 • edited

timja commented May 22, 2023

github-actions bot commented Jun 7, 2023

janfaracik commented Jun 7, 2023

mawinter69 commented Jun 7, 2023

janfaracik commented Jun 10, 2023

StefanSpieker commented Jun 11, 2023

NotMyFault commented Jun 16, 2023

timja commented Jun 16, 2023 • edited

timja commented Jun 18, 2023

yaroslavafenkin left a comment

Choose a reason for hiding this comment

NotMyFault left a comment

Choose a reason for hiding this comment

timja left a comment

Choose a reason for hiding this comment

jtnord Jul 21, 2023

Choose a reason for hiding this comment

janfaracik commented May 21, 2023 •

edited

janfaracik commented May 22, 2023 •

edited

timja commented Jun 16, 2023 •

edited