Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tippy lts #8051

Closed
wants to merge 2 commits into from
Closed

Tippy lts #8051

wants to merge 2 commits into from

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented May 25, 2023 •
edited by gitpod-io bot

See https://groups.google.com/g/jenkinsci-dev/c/sFdQNa0StR4/m/7jxURvemBQAJ

@cathychan I included both changes mentioned, but that doesn't seem to address the issue:

Screenshot 2023-05-26 at 00 17 45

Am I missing something?

@janfaracik @NotMyFault
Update link dropdown menus to use new Tippy dropdowns (jenkinsci#7474)
1c44258 
* Squashed commit of the following:

commit 0fafc6f
Merge: 9046da8 d3d1c88
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Dec 4 21:31:15 2022 +0000

    Merge branch 'master' into add-model-link-dropdowns

commit 9046da8
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Dec 4 21:31:09 2022 +0000

    Reset

commit 5f81d25
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Nov 26 00:56:02 2022 +0000

    Update prototype.js

commit dab4799
Merge: b166f01 221ff94
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Nov 25 22:32:28 2022 +0000

    Merge branch 'master' into add-model-link-dropdowns

commit b166f01
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Nov 25 20:11:45 2022 +0000

    Add support for breadcrumb-config-outline

commit cc05b74
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Nov 23 23:03:40 2022 +0000

    Imports

commit d23b822
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Nov 23 23:02:25 2022 +0000

    Tidy up JS

commit a578f6a
Merge: f48e7ef 51e084a
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Nov 23 11:13:00 2022 +0000

    Merge branch 'master' into add-model-link-dropdowns

commit f48e7ef
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Nov 23 09:57:41 2022 +0000

    Update dropdowns.less

commit 8e54b2d
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Nov 23 00:54:33 2022 +0000

    Init

commit 0a16152
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Nov 21 19:56:48 2022 +0000

    Update yarn.lock

commit 8aa08f0
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Nov 21 19:40:26 2022 +0000

    Fix

commit 7a2668c
Merge: faf3888 df89aa6
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Nov 21 19:39:51 2022 +0000

    Merge branch 'master' into add-dropdown-button

commit faf3888
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:57:35 2022 +0100

    Update overflowButton.jelly

commit 2c33dee
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:55:31 2022 +0100

    Remove unused method, fix docs

commit ed8c2b0
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:48:51 2022 +0100

    Fix link appearance

commit 9d04e80
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:45:40 2022 +0100

    Fix up

commit 109dda9
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:22:10 2022 +0100

    Small cleanup

commit 0f27194
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:19:39 2022 +0100

    Lint

commit e63c956
Merge: dccceff 7cb5eb7
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Sep 23 23:18:39 2022 +0100

    Merge branch 'master' into add-dropdown-button

commit dccceff
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 19:21:39 2022 +0100

    Update dropdowns.less

commit 373b8d9
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 19:20:40 2022 +0100

    Update table.jelly

commit 62dff83
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 19:19:51 2022 +0100

    Update index.jelly

commit 9baceda
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 19:19:32 2022 +0100

    Update rowSelectionController.jelly

commit 06591b1
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 19:18:30 2022 +0100

    Update row selection controller to use new dropdown component

commit 21b5844
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 19:02:52 2022 +0100

    Restyle

commit 9966fe7
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 18:49:06 2022 +0100

    WB

commit 81b073a
Merge: 8b58f72 315b2f4
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 27 18:29:11 2022 +0100

    Merge branch 'master' into add-dropdown-button

commit 8b58f72
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 20 08:41:48 2022 +0100

    Replace icon with hand made divs

commit 22908c7
Merge: fb89bc5 b3320ca
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Jul 19 23:28:58 2022 +0100

    Merge branch 'new-buttons-1-dashboard' into add-dropdown-button

commit fb89bc5
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Jul 19 23:28:37 2022 +0100

    Init

commit b3320ca
Merge: 1fa24ea f52d99a
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jul 14 09:50:06 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 1fa24ea
Merge: 8598f99 a990ebc
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 13 00:02:33 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 8598f99
Author: Alexander Brandes <mc.cache@web.de>
Date:   Mon Jul 11 15:11:36 2022 +0200

    style: Address stylelint violations

commit fd4da11
Merge: 0480268 aba1c17
Author: Alexander Brandes <mc.cache@web.de>
Date:   Sun Jul 10 23:30:55 2022 +0200

    Merge branch 'master' into new-buttons-1-dashboard

commit 0480268
Merge: 9b145b1 ab0bb84
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jul 9 21:52:43 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 9b145b1
Merge: 418ab06 03617e0
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Jul 8 19:44:20 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 418ab06
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jul 7 22:41:32 2022 +0100

    Update buttons-deprecated.less

commit 2798afa
Merge: 296e309 6de288f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jul 7 22:40:35 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 296e309
Merge: 1e646ff 22dcefc
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jul 7 14:50:14 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 1e646ff
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 6 22:59:13 2022 +0100

    Use rem, fix cursor for dashboard icon size

commit 21d4c73
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 6 22:56:05 2022 +0100

    Update with master, make minor changes

commit 1d59bd4
Merge: f6fc19b 644a261
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jul 6 22:48:59 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit f6fc19b
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 26 22:58:12 2022 +0100

    Update dashboard.less

commit 665daa0
Merge: a57f13a c60ea92
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 26 22:52:33 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit a57f13a
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Jun 20 19:01:18 2022 +0100

    Update simple-page.less

commit 2d3695d
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 19 22:24:32 2022 +0100

    Update theme.less

commit 361f06c
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 19 22:22:48 2022 +0100

    Split out vars

commit 205336f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 19 21:48:33 2022 +0100

    Move files about, fix focus state, fix colors

commit 204bafb
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 19 21:00:57 2022 +0100

    Update buttons to support colors

commit 1d4be07
Merge: c407577 2391319
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 19 20:01:19 2022 +0100

    Merge branch 'move-manage-jenkins-less' into new-buttons-1-dashboard

commit c407577
Merge: 0c8d538 65fcda1
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Jun 19 20:01:02 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 2391319
Merge: c9e2823 ac66b47
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 16 17:47:45 2022 +0100

    Merge branch 'master' into move-manage-jenkins-less

commit c9e2823
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 16 17:35:37 2022 +0100

    Update colors

commit c78dfd6
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 16 17:33:47 2022 +0100

    Update theme.less

commit 0996e75
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 16 17:32:52 2022 +0100

    Update theme.less

commit e57bc28
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 16 17:29:15 2022 +0100

    Update theme.less

commit 69c1633
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 16 17:00:06 2022 +0100

    Update style.less

commit e21d4e7
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 15 19:03:50 2022 +0100

    Update breadcrumbs to use new item mixin

commit 90fc4ba
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 15 18:57:51 2022 +0100

    Rename mixin

commit 28d0638
Merge: d1f42ac 65fcda1
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Jun 14 23:35:10 2022 +0100

    Merge branch 'master' into move-manage-jenkins-less

commit d1f42ac
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Jun 10 11:13:58 2022 +0100

    Update table.less

commit 13d5729
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Jun 9 10:03:01 2022 +0100

    Move from px to rem

commit 68f5425
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 8 16:40:41 2022 +0100

    Update theme.less

commit 929e2d5
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 8 16:28:06 2022 +0100

    Update mixins.less

commit 8c4b466
Merge: 8b22270 77a36fc
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 8 16:27:25 2022 +0100

    Merge branch 'master' into move-manage-jenkins-less

commit 8b22270
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 8 16:19:42 2022 +0100

    Update theme.less

commit e925490
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Jun 8 16:17:02 2022 +0100

    Add mixin for items

commit 0c8d538
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jun 4 00:15:05 2022 +0100

    Update button styling

commit 45c9d07
Merge: e9cb78a 77a36fc
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Jun 3 23:38:49 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit d579dc5
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue May 17 00:52:29 2022 +0100

    Update section.less

commit 43e4f5c
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue May 17 00:29:22 2022 +0100

    Init

commit e9cb78a
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Apr 20 21:01:06 2022 +0100

    Add backplate to table size toggles

commit 8cbfe00
Merge: 41d45b5 b28d225
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Apr 20 20:30:39 2022 +0100

    Merge branch 'master' into new-buttons-1-dashboard

commit 41d45b5
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Apr 18 12:50:17 2022 +0100

    Initial

* Remove old import

* Simplify code

* Update rowSelectionController.jelly

* Update inpage-jumplist.js

* Escape menu item labels

* Temp commenting out

* More HTMLUnit fixes

* Revert "Temp commenting out"

This reverts commit d61d943.

* Add support for left/right keyboard nav in menus, fix keyboard priority in submenus, add scroll into view, remove old menu target element

* Send error to console rather than displaying it in dropdown

* Use 'auto' for overscroll-y

* Remove Util.escape(...) from withDisplayName builder

* Remove unused import

* Show 'No items' placeholder for menus with no items

* Keep dropdown parent links active when expanded

* Update jumplists.js

* Potential fix for failing tests

* Update utils.js

* Update utils.js

* Add badge support to dropdown menus

* Remove font weight from badge

* Merge master

---------

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
(cherry picked from commit 54eb759)
@janfaracik @NotMyFault
[JENKINS-71152] The System page breadcrumb no longer displays a list …
80cacd1 
…of page sections (jenkinsci#7887)

Update inpage-jumplist.js

(cherry picked from commit 31f6dde)
@cathychan
Copy link

cathychan commented May 25, 2023 •
edited

I should have cautioned that it was just a guess 😅
Looks like @MarkEWaite found the root cause at https://issues.jenkins.io/browse/JENKINS-71345?focusedCommentId=438223&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-438223

@MarkEWaite MarkEWaite mentioned this pull request May 25, 2023
Merged
14 tasks
@NotMyFault
Copy link
Member Author

No worries, that's just a draft. But thanks to Mark for filing #8052 meanwhile.

@NotMyFault NotMyFault closed this May 26, 2023
@NotMyFault NotMyFault deleted the tippy-lts branch May 26, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NotMyFault @cathychan @janfaracik