[JENKINS-71345] Remove 'undefined' from system dropdown menu

[MarkEWaite]

JENKINS-71345 - Remove "undefined" from system dropdown menu

The "Manage Jenkins" / "System" dropdown menu includes the extra text "undefined" at the end of each entry. This removes that change and removes the updates count badge from the updates sidebar.

This reverts commit 291f5ed from

• Add updates count badge to Updates sidebar item #7084

See JENKINS-71345.

Before the fix

After the fix

Alternative to:

• Tippy lts #8051

Testing done

Confirmed that the problem was introduced by 291f5ed with a git bisect. Confirmed with interactive testing of this revert that the problem is resolved by reverting 291f5ed.

Ran the all-tests profile with mvn clean -DforkCount=1C verify on my Linux computer.

No additional test automation due to need to complete the fix quickly.

Proposed changelog entries

• Remove "undefined" trailing text from system dropdown menu.

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@NotMyFault and @janfaracik and @daniel-beck

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[NotMyFault]

Thanks

[MarkEWaite]

@timja or @janfaracik could you approve this so that it can be merged to the stable-2.401 branch in order to generate a new release candidate? I'll test the incremental build in my environment, but would like others to be able to test as well.

[basil]

Tested successfully in Firefox on Ubuntu 22.04.2 LTS x86_64.

[MarkEWaite]

Thanks to all!