Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-71429] Fix deleting users via trashcan symbol #8131

Merged
merged 1 commit into from Jun 12, 2023
Merged

[JENKINS-71429] Fix deleting users via trashcan symbol #8131

merged 1 commit into from Jun 12, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jun 11, 2023 •
edited by MarkEWaite

On manage -> Users, clicking the trash can icon lead to the old delete.jelly page that was deleted when replacing the page with a confirmation popup.
Replaced it with a confirmation link.

See JENKINS-71429.

Testing done

Manual testing:

  • Go to "Manage" -> "User"
  • Create a new user
  • click on the trash can of the new user -> confirmation dialog appears
  • click "OK"
  • user is deleted

No automated test because this portion of the code is pending further changes in:

Proposed changelog entries

  • Allow user deletion from the trash can icon (regression in 2.405).

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69
[JENKINS-71429] fix user delete
32f9cce 
On manage -> Users, clicking the delete icon lead to the old
delete.jelly page that was deleted when replacing the page with a
confirmation popup.
Replace it with a confirmation link.
MarkEWaite
MarkEWaite approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Confirmed by interactive testing that the case that was failing before is now passing.

Thanks very much for the fast response!

@MarkEWaite MarkEWaite self-assigned this Jun 11, 2023
@MarkEWaite MarkEWaite added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases bug For changelog: Minor bug. Will be listed after features labels Jun 11, 2023
@NotMyFault NotMyFault changed the title [JENKINS-71429] fix user delete [JENKINS-71429] Fix deleting users via trashcan symbol Jun 11, 2023
NotMyFault
NotMyFault approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault
Copy link
Member

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 11, 2023
@MarkEWaite MarkEWaite mentioned this pull request Jun 11, 2023
Merged
8 tasks
@NotMyFault NotMyFault removed the bug For changelog: Minor bug. Will be listed after features label Jun 12, 2023
@MarkEWaite MarkEWaite merged commit c886642 into jenkinsci:master Jun 12, 2023
15 checks passed
@mawinter69 mawinter69 mentioned this pull request Jun 14, 2023
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

@StefanSpieker StefanSpieker StefanSpieker approved these changes

Assignees

@MarkEWaite MarkEWaite

Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Milestone
No milestone
5 participants
@mawinter69 @NotMyFault @MarkEWaite @timja @StefanSpieker