Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-71246 Remove animations on login page causing high CPU usage in some cases #8147

Merged
merged 1 commit into from Jun 19, 2023

Conversation

timja
Copy link
Member

@timja timja commented Jun 14, 2023

See JENKINS-71246

Testing done

I was not able to reproduce the issue so I'll ask someone to test the build who can reproduce it.
I've ran the change and it's not animating any more:

image

Proposed changelog entries

  • JENKINS-71246 Remove animations on login page causing high CPU usage in some cases

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise labels Jun 14, 2023
@timja timja requested a review from janfaracik June 14, 2023 20:37
@timja timja marked this pull request as draft June 14, 2023 20:37
@daniel-beck
Copy link
Member

daniel-beck commented Jun 15, 2023

While it wasn't as bad as described by some for me, it's a very significant improvement.

weekly.ci vs PR build

Firefox

Before

Screenshot 2023-06-15 at 07 35 12 (2)

After

Screenshot 2023-06-15 at 07 34 47 (2)

Chrome

Before

Screenshot 2023-06-15 at 07 36 17 (2)

After

Screenshot 2023-06-15 at 07 35 50 (2)

@timja timja marked this pull request as ready for review June 15, 2023 06:09
@timja timja requested a review from a team June 15, 2023 07:25
@mawinter69
Copy link
Contributor

I can confirm that on chrome and firefox GPU usage drops to near zero on windows.

@timja
Copy link
Member Author

timja commented Jun 16, 2023

good enough for now then


/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 16, 2023
@NotMyFault NotMyFault merged commit c21d7fd into jenkinsci:master Jun 19, 2023
15 checks passed
@timja timja deleted the JENKINS-71246-high-cpu branch June 19, 2023 10:40
yaroslavafenkin pushed a commit to yaroslavafenkin/jenkins that referenced this pull request Jun 30, 2023
…in some cases (jenkinsci#8147)

JENKINS-71246 Remove animations on login page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
4 participants