Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a notice when there are no logs available #8186

Merged
merged 7 commits into from Jun 29, 2023
Merged

Display a notice when there are no logs available #8186

merged 7 commits into from Jun 29, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 25, 2023 •
edited by MarkEWaite

This PR adds a notice when there are no logs available, also introduces a reusable component/pattern for letting the user know when there is nothing to see (this could be useful for when no updates are available, if a view has no jobs, etc).

image

Testing done

  • Notice shows when there are no logs
  • Notice hides when there are logs

Proposed changelog entries

  • Display a notice in the log manager page when no logs are available.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 26, 2023
@NotMyFault NotMyFault requested a review from a team June 26, 2023 07:59
@NotMyFault NotMyFault added the needs-security-review Awaiting review by a security team member label Jun 26, 2023
@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Jun 26, 2023
@NotMyFault NotMyFault requested a review from a team June 26, 2023 16:40
@NotMyFault NotMyFault mentioned this pull request Jun 26, 2023
Closed
NotMyFault
NotMyFault approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault requested a review from a team June 27, 2023 16:32
uhafner
uhafner approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As non blocking comment: a small documentation of the attributes would be helpful.

core/src/main/resources/lib/layout/notice.jelly Outdated Show resolved Hide resolved
@timja
Copy link
Member

timja commented Jun 28, 2023

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 28, 2023
@NotMyFault NotMyFault merged commit 2fe5a55 into jenkinsci:master Jun 29, 2023
13 of 14 checks passed
@janfaracik janfaracik mentioned this pull request Jun 29, 2023
Merged
yaroslavafenkin pushed a commit to yaroslavafenkin/jenkins that referenced this pull request Jun 30, 2023
@janfaracik @yaroslavafenkin
Display a notice when there are no logs available (jenkinsci#8186)
18abe12 
* Init

* Update index.jelly

* Update index.jelly

* Remove files

* Create component

* Add docs for the attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhafner uhafner uhafner approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

@yaroslavafenkin yaroslavafenkin yaroslavafenkin approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
5 participants
@janfaracik @timja @uhafner @NotMyFault @yaroslavafenkin