Display a notice when there are plugins installed or updates available #8208

janfaracik · 2023-06-29T12:47:00Z

Followup to #8186. Adds a notice to the Installed plugins page(s) as well as to the updates page to tell the user when there are no plugins installed/updates available, this is rather than displaying the table. Also disables the search bar.

Testing done

Notice shows when no plugins are installed
Notice hides when plugins are installed
Notice shows when no updates are available
Notice hides when updates are available

Proposed changelog entries

Display a notice when plugin updates are available or when there are no plugins installed.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

NotMyFault

Tests will need a few fixes too, as it seems

core/src/main/resources/hudson/PluginManager/updates.jelly

Co-authored-by: Alexander Brandes <brandes.alexander@web.de>

yaroslavafenkin

Looks fine security wise

…rted yet

janfaracik · 2023-07-08T09:13:02Z

I've updated this to include the Installed plugins page(s) which had slipped my mind before, and I've also removed the usage of :has() as it was breaking the tests (for the time being). Rereviews and another security look over would be appreciated. Thanks

github-actions · 2023-07-10T09:16:00Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2023-07-27T07:33:03Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

daniel-beck · 2023-07-27T08:48:53Z

For UI change PRs in general, it would be useful to have both "before" and "after" screenshots (not just "after"). For example,

this

is what the plugin manager currently looks like. While the suggested change does look better, the title and description of this PR are misleading. In all three cases, a message is already shown, there's not just a table header.

timja

Looks really nice

NotMyFault

This looks nice!

timja · 2023-08-14T11:10:17Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

jenkinsci#8208) Co-authored-by: Alexander Brandes <brandes.alexander@web.de> Co-authored-by: Alexander Brandes <mc.cache@web.de> Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>

janfaracik added 10 commits April 28, 2023 22:45

Init

5e51243

Merge branch 'no-updates-notice' into empty-logs

24ce535

Update index.jelly

29a079d

Update index.jelly

026afc9

Remove files

600c6a4

Create component

6a9a85c

Add docs for the attributes

89bfdfe

Fix

0473835

Update search-bar.scss

0a07d5e

Merge branch 'master' into no-updates-notice

7f605ef

NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 30, 2023

NotMyFault reviewed Jun 30, 2023

View reviewed changes

core/src/main/resources/hudson/PluginManager/updates.jelly Outdated Show resolved Hide resolved

NotMyFault added needs-ath-build Needs to run through the full acceptance-test-harness suite needs-test-fix One or more test case(s) need to be updated labels Jun 30, 2023

janfaracik and others added 2 commits July 1, 2023 00:01

Update core/src/main/resources/hudson/PluginManager/updates.jelly

1efbf2b

Co-authored-by: Alexander Brandes <brandes.alexander@web.de>

Fix search bar not being enabled

aa39158

yaroslavafenkin reviewed Jul 4, 2023

View reviewed changes

yaroslavafenkin added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Jul 4, 2023

Add notice to Installed plugins pages, remove :has() as its not suppo…

1bf7417

…rted yet

janfaracik changed the title ~~Display a notice when there are no updates available~~ Display a notice when there are plugins installed or updates available Jul 8, 2023

janfaracik requested review from yaroslavafenkin and NotMyFault July 8, 2023 09:11

Merge branch 'master' into no-updates-notice

85d124f

Fix content

cdd59ed

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 10, 2023

Merge branch 'master' into no-updates-notice

e57db66

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 10, 2023

Merge branch 'master' into no-updates-notice

155c96a

NotMyFault removed the needs-test-fix One or more test case(s) need to be updated label Jul 17, 2023

NotMyFault removed the request for review from yaroslavafenkin July 17, 2023 21:53

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 27, 2023

Merge branch 'master' into no-updates-notice

def56f5

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 27, 2023

timja added 2 commits August 12, 2023 15:57

Merge branch 'master' into no-updates-notice

d2fd271

Merge branch 'master' into no-updates-notice

806c3c5

timja added a commit to jenkinsci/acceptance-test-harness that referenced this pull request Aug 12, 2023

Test jenkinsci/jenkins#8208

2a5be7d

timja mentioned this pull request Aug 12, 2023

Test https://github.com/jenkinsci/jenkins/pull/8208 jenkinsci/acceptance-test-harness#1325

Closed

timja added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed needs-ath-build Needs to run through the full acceptance-test-harness suite labels Aug 13, 2023

timja approved these changes Aug 14, 2023

View reviewed changes

timja requested review from a team and NotMyFault and removed request for NotMyFault August 14, 2023 07:51

NotMyFault approved these changes Aug 14, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 14, 2023

timja merged commit 83085ba into jenkinsci:master Aug 15, 2023
18 checks passed

timja deleted the no-updates-notice branch August 15, 2023 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display a notice when there are plugins installed or updates available #8208

Display a notice when there are plugins installed or updates available #8208

janfaracik commented Jun 29, 2023 •

edited by MarkEWaite

Submitter checklist

Maintainer checklist

NotMyFault left a comment

yaroslavafenkin left a comment

janfaracik commented Jul 8, 2023

github-actions bot commented Jul 10, 2023

github-actions bot commented Jul 27, 2023

daniel-beck commented Jul 27, 2023

timja left a comment

NotMyFault left a comment

timja commented Aug 14, 2023

Display a notice when there are plugins installed or updates available #8208

Display a notice when there are plugins installed or updates available #8208

Conversation

janfaracik commented Jun 29, 2023 • edited by MarkEWaite

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

NotMyFault left a comment

Choose a reason for hiding this comment

yaroslavafenkin left a comment

Choose a reason for hiding this comment

janfaracik commented Jul 8, 2023

github-actions bot commented Jul 10, 2023

github-actions bot commented Jul 27, 2023

daniel-beck commented Jul 27, 2023

timja left a comment

Choose a reason for hiding this comment

NotMyFault left a comment

Choose a reason for hiding this comment

timja commented Aug 14, 2023

janfaracik commented Jun 29, 2023 •

edited by MarkEWaite