Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-71496] Make tab pane selection reachable via keyboard #8262

Merged
merged 1 commit into from Jul 26, 2023
Merged

[JENKINS-71496] Make tab pane selection reachable via keyboard #8262

merged 1 commit into from Jul 26, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 12, 2023 •
edited by NotMyFault

tab panes (<l:tabPane...>, e.g. on the systemInfo page) are not reachable via keyboard making it impossible for people that only work with a keyboard to select the different tabs.
This change will make the tabs reachable via keyboard.

After:
image

See JENKINS-71496.
This exact issue is not mentioned in the ticket but is the same problem category.

Testing done

Manual Testing by visiting .../manage/systemInfo and pressing tab until the tabs in the page to select System Properties, Environment variables, ... are highlighted and can be shown by pressing enter

Proposed changelog entries

  • Make tab panes accessible via keyboard.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69
make tab pane selection reachable by keyboard
5e3165e 
tab panes (<l:tabPane...>, e.g. on the systemInfo page) are not reachable via keyboard
making it impossible for people that only work with a keyboard to select
the different tabs.

Not mentioned in https://issues.jenkins.io/browse/JENKINS-71496 but is
the same problem.
@mawinter69 mawinter69 changed the title make tab pane selection reachable by keyboard make tab pane selection reachable via keyboard Jul 12, 2023
@NotMyFault NotMyFault changed the title make tab pane selection reachable via keyboard [JENKINS-71496] Make tab pane selection reachable via keyboard Jul 12, 2023
@NotMyFault NotMyFault requested review from a team July 12, 2023 20:03
@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted needs-security-review Awaiting review by a security team member labels Jul 12, 2023
Wadeck
Wadeck reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from security PoV

@Wadeck Wadeck added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Jul 14, 2023
NotMyFault
NotMyFault approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault requested a review from a team July 17, 2023 21:44
@NotMyFault NotMyFault added the accessibility Improve accessibility per WCAG guidelines label Jul 17, 2023
timja
timja approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 18, 2023
@NotMyFault NotMyFault merged commit 05ebe94 into jenkinsci:master Jul 26, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wadeck Wadeck Wadeck left review comments

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
accessibility Improve accessibility per WCAG guidelines ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
4 participants
@mawinter69 @Wadeck @NotMyFault @timja