Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the design of the content blocks #8363

Merged
merged 5 commits into from Aug 15, 2023
Merged

Update the design of the content blocks #8363

merged 5 commits into from Aug 15, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Aug 12, 2023 •
edited by MarkEWaite

Small PR to update the styling of the content blocks.

  • Now uses the same colours as buttons/sidebar items/dropdown menus
  • Has the same bold focus style
  • Each item now has a relevant icon rather than a generic one
  • Removed unused selectors

Before
image

After
image

Before
image

After
image

I'm indifferent about the help link being a different colour, if anybody has any strong views I'm happy to change it back.

Testing done

  • Content blocks are updated across Jenkins and work the same
  • Selectors that have been removed are unused (searched on GitHub to confirm)

Proposed changelog entries

  • Update the design of the content blocks.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

timja
timja approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team August 12, 2023 21:15
@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 12, 2023
@timja
Copy link
Member

timja commented Aug 13, 2023

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 13, 2023
@timja timja merged commit a8a144d into jenkinsci:master Aug 15, 2023
18 checks passed
@timja timja deleted the content-blocks branch August 15, 2023 14:38
yaroslavafenkin pushed a commit to yaroslavafenkin/jenkins that referenced this pull request Sep 26, 2023
@janfaracik @timja @yaroslavafenkin
Update the design of the content blocks (jenkinsci#8363)
fb0ad4a 
Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawinter69 mawinter69 mawinter69 left review comments

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

@StefanSpieker StefanSpieker StefanSpieker approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
5 participants
@janfaracik @timja @NotMyFault @mawinter69 @StefanSpieker