New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move app bar for plugins #8376
Move app bar for plugins #8376
Conversation
war/src/main/js/plugin-manager-ui.js
Outdated
@@ -59,6 +59,10 @@ var handleFilter = function (e) { | |||
var debouncedFilter = debounce(handleFilter, 150); | |||
|
|||
document.addEventListener("DOMContentLoaded", function () { | |||
document | |||
.querySelector("#side-panel") | |||
.classList.add("app-page-body__sidebar--sticky"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be a feature of the sidebar? Is there a reason you aren't adding it in jelly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it should be, was a workaround until this #8269 is implemented. I can remove it from this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
* Move app bar for plugins, make sidebar sticky * Update _updateSite.js * Remove sticky side panel
A small update to the Plugins interface -
Makes the sidebar persist as you scroll downRemoved in favour of [JENKINS-71578] allow making sidepanel sticky #8269The advantage to this is that's it's more space efficient and brings it inline with other pages, such as Configure project and Design Library.
Before
After
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).