Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move app bar for plugins #8376

Merged
merged 3 commits into from Aug 21, 2023
Merged

Move app bar for plugins #8376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1ea9b1
Move app bar for plugins, make sidebar sticky
janfaracik Aug 15, 2023
017de5e
Update _updateSite.js
janfaracik Aug 15, 2023
45097cd
Remove sticky side panel
janfaracik Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/src/main/resources/hudson/PluginManager/available.jelly
View file
Open in desktop
Expand Up @@ -32,8 +32,6 @@ THE SOFTWARE.
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />

<div class="jenkins-app-bar jenkins-app-bar--sticky">
<div class="jenkins-app-bar__content">
<l:search-bar clazz="jenkins-search--app-bar"
Expand Down
2 changes: 0 additions & 2 deletions core/src/main/resources/hudson/PluginManager/installed.jelly
View file
Open in desktop
Expand Up @@ -34,8 +34,6 @@ THE SOFTWARE.
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />

<j:set var="noPlugins"
value="${empty(app.pluginManager.plugins) and empty(app.pluginManager.failedPlugins)}" />

Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/PluginManager/sidepanel.jelly
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@ THE SOFTWARE.
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
<l:side-panel>
<l:app-bar title="${%Plugins}" />
<l:tasks>
<l:task href="${rootURL}/manage/pluginManager/" icon="symbol-download" title="${%Updates}" badge="${app.updateCenter.badge}"/>
<l:task href="${rootURL}/manage/pluginManager/available" icon="symbol-shopping-bag" title="${%Available plugins}"/>
Expand Down
2 changes: 0 additions & 2 deletions core/src/main/resources/hudson/PluginManager/updates.jelly
View file
Open in desktop
Expand Up @@ -35,8 +35,6 @@ THE SOFTWARE.
</l:header>

<l:main-panel>
<l:app-bar title="${%Plugins}" />

<div class="jenkins-app-bar jenkins-app-bar--sticky">
<div class="jenkins-app-bar__content">
<l:search-bar clazz="jenkins-search--app-bar"
Expand Down
1 change: 1 addition & 0 deletions war/src/main/scss/form/search-bar.scss
View file
Open in desktop
Expand Up @@ -191,6 +191,7 @@
--search-bar-height: 3rem;

max-width: 50vw;
margin-block: -6px;

&::before {
content: "";
Expand Down