Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-71880] fix notification in breadcrumb #8493

Merged
merged 2 commits into from Sep 20, 2023
Merged

[JENKINS-71880] fix notification in breadcrumb #8493

merged 2 commits into from Sep 20, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Sep 15, 2023 •
edited by MarkEWaite

fix the notification when e.g. triggering a build via the breadcrumb.

replace the hoverNotification with a notificationBar. When the hoverNotification appears the actual menu disappears making the notification somehow look misplaced.
Prepend the message with the actual menu entry to make it more clear what the message means.

Capture.2023-09-15.170423.mp4

It would be beneficial that the message contains the same message as when clicking on the "Build Now" in the side panel ("Build Scheduled") but that would require bigger changes -> something for a separate PR.

See JENKINS-71880.

Testing done

Triggering a build without parameters

Proposed changelog entries

  • Show a confirmation popup when triggering l:task action from context menu.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69
[JENKINS-71880] fix notification in breadcrumb
2b004d6 
fix the notification when e.g. triggering a build via the breadcrumb.

replace the hoverNotification with a notificationBar. When the
hoverNotification appears the actual menu disappears making the
notification somehow look misplaced.
Prepend the message with the actual menu entry to make it more clear
what the message means.
@daniel-beck daniel-beck added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Sep 15, 2023
daniel-beck
daniel-beck approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! Interactive testing works nicely for me.

NotMyFault
NotMyFault approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 17, 2023
@NotMyFault NotMyFault merged commit c8874d0 into jenkinsci:master Sep 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Milestone
No milestone
3 participants
@mawinter69 @daniel-beck @NotMyFault