[JENKINS-72111] Allow Lifecycle to load implementations from plugins
#8589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
approved these changes
Oct 10, 2023
jglick
commented
Oct 10, 2023
There was a problem hiding this comment.
I retained sources in the plugin archive, but for the convenience of reviewers:
package test.custom_lifecycle;
import hudson.lifecycle.Lifecycle;
public final class CustomLifecycle extends Lifecycle {
public int count;
@Override
public void restart() {
count++;
}
}| activePlugins.add(p); | ||
| ((UberClassLoader) uberClassLoader).clearCacheMisses(); |
There was a problem hiding this comment.
I found that UberClassLoader.loaded cached class loading misses after plugins were loaded during startup. This would not normally be noticeable, but in this case a call to Lifecycle.get before initializing plugins would cache the miss and it would not subsequently be cleared.
Comment on lines
-937
to
+939
| ((UberClassLoader) uberClassLoader).loaded.clear(); | ||
| ((UberClassLoader) uberClassLoader).clearCacheMisses(); |
There was a problem hiding this comment.
This is for dynamic plugin loading, so already cleared the cache, though also cache hits which seemed unnecessary.
Vlatombe
changed the title
Lifecycle to load implementations from pluginsLifecycle to load implementations from plugins
timja
approved these changes
Oct 10, 2023
jtnord
approved these changes
Oct 11, 2023
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
comment-ops-bot
bot
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-72111 and #8555 (comment). Unlike the original PR, this requires no API change or plugin initializer, just the existing system property—which had long used
UberClassLoaderbut did not work for a class defined in a plugin.Testing done
The functional test added here, as well as validation that this works for a
Lifecycleimplementation in a plugin in CloudBees CI when the system property is set. (Without this patch, setting the system property to the plugin-defined class causes a boot failure, since the class is not loadable whenLifecycle.getis first called early during startup.)Proposed changelog entries
Lifecycle.Desired reviewers
@Vlatombe @jtnord
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).