Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle.supportsDynamicLoad #9013

Merged
merged 1 commit into from Mar 10, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 4, 2024

In CloudBees CI running in high availability mode we run a custom lifecycle (#8589) which is not compatible with the option to dynamically install a plugin. While an individual plugin can be marked on the update center as requiring a controller restart to install, this was not available generically for any plugin. Lifecycle seems like the right place for it since it already defined when and how to restart.

Testing done

Interactively tested inside CloudBees CI by overriding this method.

Proposed changelog entries

  • N/A, beta-only API

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@NotMyFault NotMyFault requested a review from a team March 9, 2024 14:33
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Mar 9, 2024
@MarkEWaite
Copy link
Contributor

/label ready-for-merge

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 9, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@NotMyFault NotMyFault merged commit 46b0db7 into jenkinsci:master Mar 10, 2024
16 checks passed
@jglick jglick deleted the supportsDynamicLoad branch March 11, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
5 participants