Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish localization fixes for login and users management pages #8631

Merged
merged 1 commit into from Oct 26, 2023

Conversation

mustafau
Copy link
Contributor

Testing done

Screen Shot 2023-10-22 at 20 43 51 Screen Shot 2023-10-22 at 20 44 19 Screen Shot 2023-10-22 at 20 44 38

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@NotMyFault NotMyFault added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback localization labels Oct 23, 2023
@NotMyFault NotMyFault merged commit 9de992b into jenkinsci:master Oct 26, 2023
16 checks passed
@mustafau mustafau deleted the tr_users_management branch October 26, 2023 21:24
flabrie pushed a commit to flabrie/jenkins that referenced this pull request Oct 30, 2023
* master: (72 commits)
  [JENKINS-72189] fix drag&drop handle for existing repeatables (jenkinsci#8613)
  [JENKINS-72222] Fix inconsistent wording between login page and security configuration (jenkinsci#8633)
  More helpful error message for `ExtensionList.lookupSingleton` (jenkinsci#8646)
  Turkish localization fixes for build page (jenkinsci#8651)
  Update dependabot branch for LTS 2.426.x (jenkinsci#8659)
  Update dependency node to v20.9.0 (jenkinsci#8656)
  Update dependency sass to v1.69.5 (jenkinsci#8657)
  Bump org.jenkins-ci.main:jenkins-test-harness from 2096.vcfd8fa_a_67f86 to 2099.vc95b_86578f37 (jenkinsci#8653)
  Bump org.jenkins-ci.main:remoting from 3190.va_7870fc137d9 to 3192.v713e3b_039fb_e (jenkinsci#8654)
  Bump org.jenkins-ci.plugins:credentials from 1304.v5ec13eecef46 to 1307.v3757c78f17c3 (jenkinsci#8655)
  Bump commons-io:commons-io from 2.14.0 to 2.15.0 (jenkinsci#8647)
  Update Yarn to v4 (jenkinsci#8641)
  Bump org.jenkins-ci.plugins:credentials from 1293.vff276f713473 to 1304.v5ec13eecef46 (jenkinsci#8650)
  Bump org.jenkins-ci.main:remoting from 3186.vc3b_7249b_87eb_ to 3190.va_7870fc137d9 (jenkinsci#8649)
  Fix issues with help texts under security configuration (jenkinsci#8630)
  Turkish localization fixes for login and users management pages (jenkinsci#8631)
  Bump com.github.eirslett:frontend-maven-plugin from 1.14.0 to 1.14.2 (jenkinsci#8648)
  Bump org.jenkins-ci.main:remoting from 3181.v78543a_987053 to 3186.vc3b_7249b_87eb_ (jenkinsci#8643)
  Bump org.jenkins-ci.main:jenkins-test-harness from 2090.v6d1706e434a_b_ to 2096.vcfd8fa_a_67f86 (jenkinsci#8642)
  [maven-release-plugin] prepare for next development iteration
  ...

# Conflicts:
#	core/src/main/resources/lib/form/repeatable.jelly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
2 participants