[JENKINS-72189] fix drag&drop handle for existing repeatables #8613

mawinter69 · 2023-10-16T13:18:23Z

The drag&drop handle for <f:repeatable header="Header"> is missing for existing entries when opening a configure page and the styling of the header is wrong.
Newly added entries do have the handle and can be moved.

Before:

After:

See JENKINS-72189.

Testing done

Manual testing as described in the Jira

Proposed changelog entries

JENKINS-72189, fix drag&drop handle for existing repeatables

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

NotMyFault · 2023-10-19T21:58:51Z

ATH failed in jenkinsci/acceptance-test-harness#1393

mawinter69 · 2023-10-19T22:15:35Z

The test failures don't seem to be related to this change. They look more as being caused by the new version of the folder plugin

NotMyFault

Thanks!

mawinter69 · 2023-10-29T11:25:54Z

Would it be possible to get this in the next LTS @MarkEWaite

MarkEWaite · 2023-10-29T13:42:31Z

Would it be possible to get this in the next LTS @MarkEWaite

Thanks for asking @mawinter69 . It becomes eligible for backporting after it has been included in a weekly release. If it can be included in the 2.430 release on Tuesday, 31 Oct 2023, then it could be included in the 2.426.1 release candidate that will be made available Wednesday, 1 Nov 2023.

If it is not delivered in a weekly release until 2.431, it could be included in a rebuild of the 2.426.1 release candidate. We've done that before for important fixes.

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

* master: (72 commits) [JENKINS-72189] fix drag&drop handle for existing repeatables (jenkinsci#8613) [JENKINS-72222] Fix inconsistent wording between login page and security configuration (jenkinsci#8633) More helpful error message for `ExtensionList.lookupSingleton` (jenkinsci#8646) Turkish localization fixes for build page (jenkinsci#8651) Update dependabot branch for LTS 2.426.x (jenkinsci#8659) Update dependency node to v20.9.0 (jenkinsci#8656) Update dependency sass to v1.69.5 (jenkinsci#8657) Bump org.jenkins-ci.main:jenkins-test-harness from 2096.vcfd8fa_a_67f86 to 2099.vc95b_86578f37 (jenkinsci#8653) Bump org.jenkins-ci.main:remoting from 3190.va_7870fc137d9 to 3192.v713e3b_039fb_e (jenkinsci#8654) Bump org.jenkins-ci.plugins:credentials from 1304.v5ec13eecef46 to 1307.v3757c78f17c3 (jenkinsci#8655) Bump commons-io:commons-io from 2.14.0 to 2.15.0 (jenkinsci#8647) Update Yarn to v4 (jenkinsci#8641) Bump org.jenkins-ci.plugins:credentials from 1293.vff276f713473 to 1304.v5ec13eecef46 (jenkinsci#8650) Bump org.jenkins-ci.main:remoting from 3186.vc3b_7249b_87eb_ to 3190.va_7870fc137d9 (jenkinsci#8649) Fix issues with help texts under security configuration (jenkinsci#8630) Turkish localization fixes for login and users management pages (jenkinsci#8631) Bump com.github.eirslett:frontend-maven-plugin from 1.14.0 to 1.14.2 (jenkinsci#8648) Bump org.jenkins-ci.main:remoting from 3181.v78543a_987053 to 3186.vc3b_7249b_87eb_ (jenkinsci#8643) Bump org.jenkins-ci.main:jenkins-test-harness from 2090.v6d1706e434a_b_ to 2096.vcfd8fa_a_67f86 (jenkinsci#8642) [maven-release-plugin] prepare for next development iteration ... # Conflicts: # core/src/main/resources/lib/form/repeatable.jelly

…sci#8613) [JENKINS-72189] fix drag&drop handle for repeatables (cherry picked from commit c5442a0)

mawinter69 added 2 commits October 16, 2023 15:07

[JENKINS-72189] fix drag&drop handle for repeatables

2bee965

Merge branch 'master' into JENKINS-72189

94b8364

NotMyFault added a commit to NotMyFault/acceptance-test-harness that referenced this pull request Oct 18, 2023

Test jenkinsci/jenkins#8613

a50e42d

NotMyFault mentioned this pull request Oct 18, 2023

Test https://github.com/jenkinsci/jenkins/pull/8613 jenkinsci/acceptance-test-harness#1393

Closed

NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Oct 18, 2023

NotMyFault requested a review from a team October 18, 2023 21:54

NotMyFault added the ath-fail The acceptance-test-harness suite needs a forward-compatible change label Oct 19, 2023

NotMyFault added a commit to NotMyFault/acceptance-test-harness that referenced this pull request Oct 21, 2023

Test jenkinsci/jenkins#8613

43cc817

NotMyFault added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed ath-fail The acceptance-test-harness suite needs a forward-compatible change labels Oct 22, 2023

NotMyFault approved these changes Oct 22, 2023

View reviewed changes

NotMyFault requested review from a team October 22, 2023 11:10

timja approved these changes Oct 29, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 29, 2023

NotMyFault merged commit c5442a0 into jenkinsci:master Oct 30, 2023
17 checks passed

MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Oct 31, 2023

[JENKINS-72189] fix drag&drop handle for existing repeatables (jenkin…

4a65841

…sci#8613) [JENKINS-72189] fix drag&drop handle for repeatables (cherry picked from commit c5442a0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-72189] fix drag&drop handle for existing repeatables #8613

[JENKINS-72189] fix drag&drop handle for existing repeatables #8613

mawinter69 commented Oct 16, 2023 •

edited

Submitter checklist

Maintainer checklist

NotMyFault commented Oct 19, 2023

mawinter69 commented Oct 19, 2023

NotMyFault left a comment

mawinter69 commented Oct 29, 2023

MarkEWaite commented Oct 29, 2023 •

edited

timja left a comment

[JENKINS-72189] fix drag&drop handle for existing repeatables #8613

[JENKINS-72189] fix drag&drop handle for existing repeatables #8613

Conversation

mawinter69 commented Oct 16, 2023 • edited

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

NotMyFault commented Oct 19, 2023

mawinter69 commented Oct 19, 2023

NotMyFault left a comment

Choose a reason for hiding this comment

mawinter69 commented Oct 29, 2023

MarkEWaite commented Oct 29, 2023 • edited

timja left a comment

Choose a reason for hiding this comment

mawinter69 commented Oct 16, 2023 •

edited

MarkEWaite commented Oct 29, 2023 •

edited