Restore JCasC compatibility for JNLPLauncher.tunnel
#8793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8762 seems to have broken JCasC compatibility for agent definitions using
tunnel
, which is probably unusual but happened to be used by an integration test in CloudBees CI.I suspect the reason is that
DataBoundConfigurator
is buggy and does not support@DataBoundSetter
on fields, which despite the name is supported by Jenkins core: it never actually looks for this annotation, and perhaps just assumes that getter/setter pairs not covered by the@DataBoundConstructor
are properties.Testing done
jenkinsci/configuration-as-code-plugin#2441
Removal of
@Deprecated
seems to only be necessary for compatibility with CloudBees CI, which has its own CasC reflection code not based on JCasC and which appears to check for the@Deprecated
annotation on fields rather than on setters. (For @cloudbees only: verified running selected tests in thecom.cloudbees.casc.server.items
package.)Proposed changelog entries
tunnel
property on aninbound
agent was inadvertently broken for JCasC usage in 2.437. It remains deprecated and usages should be deleted (regression in 2.437).Proposed upgrade guidelines
N/A
Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).