Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73011] Round-trip JNLPLauncher.tunnel to null not "" #9170

Merged
merged 1 commit into from Apr 15, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 14, 2024

See JENKINS-73011. Amends #8762 + #8793.

Testing done

Automated test; also confirmed bug interactively in 2.426.3 → 2.440.2.

Proposed changelog entries

  • After reconfiguring a static inbound agent in the GUI using fields such as WebSocket deprecated in 2.440.x, the suggested launch instructions would incorrectly include -tunnel (with no argument) even if that field had been left blank.

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Apr 14, 2024
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 14, 2024
@MarkEWaite MarkEWaite self-assigned this Apr 14, 2024
@MarkEWaite MarkEWaite merged commit 13dc52c into jenkinsci:master Apr 15, 2024
16 checks passed
@jglick jglick deleted the tunnel-JENKINS-73011 branch April 15, 2024 14:12
NotMyFault pushed a commit to NotMyFault/jenkins that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
4 participants