Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71965] fix timezone in build history #8800

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Dec 22, 2023

the timezone shown was always the daylight saving timezone when the users selected timezone has daylight saving. The change will now consider the actual timestamp of the build to determine if it was in daylight saving time to properly calculate the timezone to show.
The timezone is now also locale aware

Before:
All entries showed CEST

After:
With Europe/Berlin
image
With Europe/London
image
With Europe/Berlin and german locale:
image

See JENKINS-71965.

Testing done

Manual testing

Proposed changelog entries

  • Display correct time zone in build history.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

the timezone shown was always the daylight saving time when the users
selected timezone has daylight saving. The change will now consider the
actual timestamp of the build to determine if it was in daylight saving
time to properly calculate the timezone to show.
@NotMyFault NotMyFault requested a review from a team December 23, 2023 11:40
@NotMyFault NotMyFault added the bug For changelog: Minor bug. Will be listed after features label Dec 23, 2023
@timja
Copy link
Member

timja commented Dec 23, 2023

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 23, 2023
@MarkEWaite MarkEWaite merged commit 48da635 into jenkinsci:master Dec 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
4 participants