Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not generate td when outside table for buildbutton #8854

Merged
merged 1 commit into from Jan 13, 2024
Merged

do not generate td when outside table for buildbutton #8854

merged 1 commit into from Jan 13, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jan 10, 2024 •
edited by MarkEWaite

projectView renders a buildButton twice once inside a table for wide screens and once outside a table for narrow or mobile screens with one always hidden. But the buildButton always wraps everything in a td. When projectView is now itself wrapped somewhere in a table (was done in dashboard-view plugin) then the brwoser will move the td to the outer table and it gets always shown and breaks the UI.

See jenkinsci/dashboard-view-plugin#294

Testing done

Install dashboard-view plugin and create a view with the Jenkins jobs list portlet added to one of the Portlet containers.
Prior to the fix UI is broken, with fix everything looks as expected

Proposed changelog entries

  • Fix build button rendering for dashboard view plugin.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69
do not generate td when outside table for buildbutton
f172cd9 
projectView renders a buildButton twice once inside a table for wide
screens and once outside a table for narrow or mobile screens with one
always hidden. But the buildButton always wraps everything in a `td`.
When projectView is now itself wrapped somewhere in a table (was done
in dashboard-view plugin) then the brwoser will move the `td` to the
outer table and it gets always shown and breaks the UI.
timja
timja approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, untested

@timja timja added the bug For changelog: Minor bug. Will be listed after features label Jan 10, 2024
@NotMyFault NotMyFault requested a review from a team January 10, 2024 22:59
@NotMyFault NotMyFault added the needs-security-review Awaiting review by a security team member label Jan 10, 2024
@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Jan 11, 2024
@NotMyFault NotMyFault removed the request for review from a team January 12, 2024 10:43
NotMyFault
NotMyFault approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 12, 2024
@MarkEWaite MarkEWaite merged commit 53f7e40 into jenkinsci:master Jan 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiX TobiX TobiX approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues
Projects
None yet
Milestone
No milestone
6 participants
@mawinter69 @TobiX @NotMyFault @timja @MarkEWaite @yaroslavafenkin