Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-72711] Restore progress animation in build history and buildtime trend views #8966

Merged
merged 1 commit into from Feb 19, 2024
Merged

[JENKINS-72711] Restore progress animation in build history and buildtime trend views #8966

merged 1 commit into from Feb 19, 2024

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Feb 16, 2024 •
edited by MarkEWaite

… time trend views

See JENKINS-72711.

Amends #8705

Testing done

Looked at the affected pages while builds were running while the previous build was: green, red, aborted, notbuilt, canceled.

Confirmed no other views include the responsible JS file (and would need these definitions).

Proposed changelog entries

  • Restore progress animation in build history and build time trend views (regression in 2.434).

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases bug For changelog: Minor bug. Will be listed after features labels Feb 16, 2024
@NotMyFault NotMyFault requested a review from a team February 17, 2024 14:25
@mawinter69
Copy link
Contributor

Not something for this PR but the many svg we include also blow up the html and usually most of them are not really needed (but one never knows). And I also have that in one of my plugins. So it would be nice to have the possibility to request a svg xml via fetch in javascript and just pass the symbol you want, e.g. <jenkinsurl>/symbol?name=symbol-star-outline plugin-ionicons-api
Or we provide directly a method and expose it to plugins.
getJenkinsSymbol("symbol-star-outline plugin-ionicons-api"), things like tooltip, htmltooltip, alt or id can be added as well

NotMyFault
NotMyFault approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault
Copy link
Member

Not something for this PR but the many svg we include also blow up the html and usually most of them are not really needed (but one never knows). And I also have that in one of my plugins. So it would be nice to have the possibility to request a svg xml via fetch in javascript and just pass the symbol you want, e.g. <jenkinsurl>/symbol?name=symbol-star-outline plugin-ionicons-api Or we provide directly a method and expose it to plugins. getJenkinsSymbol("symbol-star-outline plugin-ionicons-api"), things like tooltip, htmltooltip, alt or id can be added as well

Possibly worth filing a dedicated issue linking this PR?

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 18, 2024
@NotMyFault NotMyFault changed the title [JENKINS-72711] Restore progress animation in build history and build… [JENKINS-72711] Restore progress animation in build history and buildtime trend views Feb 18, 2024
@NotMyFault NotMyFault removed the bug For changelog: Minor bug. Will be listed after features label Feb 19, 2024
@NotMyFault NotMyFault merged commit f91d1ec into jenkinsci:master Feb 19, 2024
16 checks passed
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Mar 5, 2024
@daniel-beck @krisstern
[JENKINS-72711] Restore progress animation in build history and build…
72cea0e 
…time trend views (jenkinsci#8966)

[JENKINS-72711] Restore progress animation in build history and build time trend views

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
(cherry picked from commit f91d1ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Milestone
No milestone
4 participants
@daniel-beck @mawinter69 @NotMyFault @timja