[JENKINS-73007] Create-item button no longer disabled when duplicate name present

[janfaracik]

See JENKINS-73007.

Missed this selector in #9111 - this PR fixes that so the submit button disables as expected. Tried to reproduce 73007 in an older version of Jenkins and couldn't sadly, the button was enabled despite the duplicate name. To fix this I've added enableSubmit(false); to set the button to be disabled when there's a duplicate item.

Testing done

• Button disables as expected, also when there's a duplicate project name
• Button enables as expected

Proposed changelog entries

• [JENKINS-73007] Create-item button no longer disabled when duplicate name present

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. The Jira issue, if it exists, is well-described.

   The Jira issue, if it exists, is well-described.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

   The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. There is automated testing or an explanation as to why this change has no tests.

   There is automated testing or an explanation as to why this change has no tests.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

   New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

   New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

   New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.

   For dependency updates, there are links to external changelogs and, if possible, full differentials.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
8. For new APIs and extension points, there is a link to at least one consumer.

   For new APIs and extension points, there is a link to at least one consumer.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title

Beta Give feedback Tasklist Maintainer checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.

   There are at least two (2) approvals for the pull request and no outstanding requests for change.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

   Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

   Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Proper changelog labels are set so that the changelog can be generated automatically.

   Proper changelog labels are set so that the changelog can be generated automatically.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

   If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

   If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Maintainer checklist

[timja]

untested looks good though

[NotMyFault]

Thanks for the prompt fix!

---

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[daniel-beck]

Create-item button no longer disabled when duplicate name present

I tried with 2.454 and this doesn't do what it claims it does:

It only disables the button if the name is edited after selecting a type, which should be exceedingly rare.

I filed JENKINS-73034.