Refresh the 'New item' page #9111

janfaracik · 2024-04-01T20:38:56Z

Small pull request to refresh the 'New item' page. Largely some SCSS changes to bring it more inline with the rest of Jenkins, as well as some minor JS changes.

Before

After

Added a page heading and breadcrumb item
Removed the always present 'Required field' text
Removed the icon background
Sticky bottom bar has been replaced with the bottomButtonBar component

Testing done

Works as before, needs passing tests

Proposed changelog entries

Refresh the 'New item' page.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

timja

not ran locally but screenshots look good, what's with the empty functions?

war/src/main/js/add-item.js

janfaracik · 2024-04-02T08:18:15Z

Design is far from perfect but I think it's a step in the right direction - if anybody has any ideas happy to hear them.

The items are loaded in by JS - anybody know the reason why this is over just loading them in via Jelly? Any performance considerations?

timja · 2024-04-02T11:35:06Z

The items are loaded in by JS - anybody know the reason why this is over just loading them in via Jelly? Any performance considerations?

I think it was being done in the 2.x refresh which was when the setup wizard came in so likely it was using similar paradigms and approaches to it.

NotMyFault · 2024-04-03T05:44:01Z

Unrelated to this pr, but related to future cleanups: https://issues.jenkins.io/browse/JENKINS-72947

timja

LGTM

yaroslavafenkin

Looks OK security wise.

NotMyFault

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

daniel-beck · 2024-04-04T09:54:05Z

Animations for keyboard navigation on this page looks weird because of close/overlapping focus boxes for the item types. Is this intentional?

Also pointing out that removing the .flat class from the div results in item grouping. #5083 intended to implement that, but circumstances at the time resulted it in me having to postpone it.

It looks reasonable to me but perhaps not up to your standards, PTAL

(Neither are blocking.)

janfaracik · 2024-04-05T16:36:39Z

Animations for keyboard navigation on this page looks weird because of close/overlapping focus boxes for the item types. Is this intentional?

Also pointing out that removing the .flat class from the div results in item grouping. #5083 intended to implement that, but circumstances at the time resulted it in me having to postpone it.

It looks reasonable to me but perhaps not up to your standards, PTAL
(Neither are blocking.)

Good spot about the border overlapping, I've increased the spacing a touch to account for that.

As for grouping, I think it looks alright for now - can always revisit in the future.

janfaracik added 2 commits April 1, 2024 21:32

Init

db3121e

Remove br

1e4c5b6

timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Apr 2, 2024

timja requested a review from a team April 2, 2024 07:29

timja reviewed Apr 2, 2024

View reviewed changes

war/src/main/js/add-item.js Outdated Show resolved Hide resolved

war/src/main/js/add-item.js Outdated Show resolved Hide resolved

janfaracik added 2 commits April 2, 2024 09:16

Remove unused functions

11f07ac

Merge branch 'master' into tidy-new-item-page

e231913

janfaracik added 2 commits April 2, 2024 22:37

Remove div class assertion

7af4749

Merge branch 'master' into tidy-new-item-page

0ff2d10

timja added the needs-security-review Awaiting review by a security team member label Apr 3, 2024

timja requested a review from a team April 3, 2024 13:03

timja approved these changes Apr 3, 2024

View reviewed changes

timja requested a review from a team April 3, 2024 13:11

yaroslavafenkin approved these changes Apr 3, 2024

View reviewed changes

yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Apr 3, 2024

NotMyFault approved these changes Apr 3, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 3, 2024

mawinter69 mentioned this pull request Apr 4, 2024

[JENKINS-72947] Support symbols in TopLevelItemDescriptor#getIconClassName() #9127

Merged

Increase gap between items

8738507

Merge branch 'master' into tidy-new-item-page

e8c4598

NotMyFault merged commit 864b275 into jenkinsci:master Apr 5, 2024
17 checks passed

janfaracik deleted the tidy-new-item-page branch April 5, 2024 22:20

janfaracik mentioned this pull request Apr 13, 2024

[JENKINS-73007] Create-item button no longer disabled when duplicate name present #9167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refresh the 'New item' page #9111

Refresh the 'New item' page #9111

janfaracik commented Apr 1, 2024 •

edited by MarkEWaite

Submitter checklist

Maintainer checklist

timja left a comment

janfaracik commented Apr 2, 2024

timja commented Apr 2, 2024

NotMyFault commented Apr 3, 2024

timja left a comment

yaroslavafenkin left a comment

NotMyFault left a comment

daniel-beck commented Apr 4, 2024 •

edited

janfaracik commented Apr 5, 2024

Refresh the 'New item' page #9111

Refresh the 'New item' page #9111

Conversation

janfaracik commented Apr 1, 2024 • edited by MarkEWaite

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja left a comment

Choose a reason for hiding this comment

janfaracik commented Apr 2, 2024

timja commented Apr 2, 2024

NotMyFault commented Apr 3, 2024

timja left a comment

Choose a reason for hiding this comment

yaroslavafenkin left a comment

Choose a reason for hiding this comment

NotMyFault left a comment

Choose a reason for hiding this comment

daniel-beck commented Apr 4, 2024 • edited

janfaracik commented Apr 5, 2024

janfaracik commented Apr 1, 2024 •

edited by MarkEWaite

daniel-beck commented Apr 4, 2024 •

edited