Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup "Hudson" references in the Jenkinsfile Runner codebase #378

Merged
merged 13 commits into from
Oct 5, 2020
Merged

Cleanup "Hudson" references in the Jenkinsfile Runner codebase #378

merged 13 commits into from
Oct 5, 2020

Conversation

darkphoenix17
Copy link
Contributor

@darkphoenix17 darkphoenix17 commented Oct 4, 2020 •
edited by oleg-nenashev

Contributes to #375

darkphoenix17 and others added 12 commits September 30, 2020 19:27
@darkphoenix17
Changes made from 'Hudson' to 'Jenkins'
db96ff0
@darkphoenix17
File name changed as well along with import path
ea8416b
@darkphoenix17
Revert "Changes made from 'Hudson' to 'Jenkins'"
28229e8 
This reverts commit db96ff0.
@darkphoenix17
Solved Issue
32e0f03
@darkphoenix17
Merge pull request #1 from darkphoenix17/dev
24dcf9a 
Dev
@darkphoenix17
Revert "Solved Issue"
ca75a82 
This reverts commit 32e0f03.
@darkphoenix17
Issue solved effectively without errors in vscode
c24b1a1
@darkphoenix17
Revert "Issue solved effectively without errors in vscode"
05e2835 
This reverts commit c24b1a1.
@darkphoenix17 @PierreBtz @oleg-nenashev
Solved merge conflict (#3)
7118e4d 
* Add a withHooks flag to provide a hook directory

fixes jenkinsci#359

* Apply suggestions from code review

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>

* Rename the withHooks flag to withInitHooks

Co-authored-by: Pierre Beitz <pibeitz@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@darkphoenix17
solve try 3
add4028
@darkphoenix17
Merge branch 'solve_issue' into dev
56e76e4
@darkphoenix17
Merge pull request #4 from darkphoenix17/dev
c905fcf 
solve_issue try 3
@darkphoenix17 darkphoenix17 requested a review from a team as a code owner October 4, 2020 18:08
oleg-nenashev
oleg-nenashev approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely a net improvement. Thanks for your contribution @darkphoenix17 !

@oleg-nenashev oleg-nenashev added the internal Internal change which does not impact users label Oct 5, 2020
@oleg-nenashev oleg-nenashev changed the title Solved Replace Issue Cleanup "Hudson" references in the Jenkinsfile Runner codebase Oct 5, 2020
@oleg-nenashev oleg-nenashev linked an issue Oct 5, 2020 that may be closed by this pull request
Replace "Hudson" by "Jenkins" in the codebase #375
Closed
@oleg-nenashev oleg-nenashev merged commit 8ac6463 into jenkinsci:master Oct 5, 2020
@oleg-nenashev
Copy link
Member

@darkphoenix17 if you are interested, a similar patch could be applied to the Jenkins Test harness codebase: https://github.com/jenkinsci/jenkins-test-harness which was originator of the code. Note that there Binary compatibility should be retained, so it is not possible to just rename classes and methods

@oleg-nenashev oleg-nenashev mentioned this pull request Oct 5, 2020
Closed
@darkphoenix17
Copy link
Contributor Author

@oleg-nenashev can this PR be eligible for hacktoberfest? If so, Can you add the hacktoberfest label?

@darkphoenix17
Copy link
Contributor Author

@darkphoenix17 if you are interested, a similar patch could be applied to the Jenkins Test harness codebase: https://github.com/jenkinsci/jenkins-test-harness which was originator of the code. Note that there Binary compatibility should be retained, so it is not possible to just rename classes and methods

Yeah, I am very much interested. Looking forward to the issue.

@darkphoenix17
Copy link
Contributor Author

darkphoenix17 commented Oct 8, 2020 •
edited

@darkphoenix17 if you are interested, a similar patch could be applied to the Jenkins Test harness codebase: https://github.com/jenkinsci/jenkins-test-harness which was originator of the code. Note that there Binary compatibility should be retained, so it is not possible to just rename classes and methods

Hello @oleg-nenashev , I looked through the code base and tried to understand the workflow so that I can make the necessary changes of the name.
The code of that repo is more complex than the current repo which I was working on.... could you provide me some initial steps to start working on in some form of bullets task.
Also can you open an issue and assign it to me to that i can make a PR.
Waiting for your reply!!!

@darkphoenix17 darkphoenix17 mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted internal Internal change which does not impact users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "Hudson" by "Jenkins" in the codebase
2 participants
@darkphoenix17 @oleg-nenashev