Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-33166 check for nonnull url inside constructor #100

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

escoem
Copy link
Contributor

@escoem escoem commented May 13, 2016

If you try to add and empty jira plugin configuration at Manage Jenkins, will fail with NPE.


This change is Reviewable

@rantoniuk
Copy link
Contributor

Actually we shouldn't allow adding a JIRA site with an empty URL, what's the point ?:)
I think it is better to make the URL field required on the UI if possible.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.058% when pulling b7d807c on escoem:JENKINS-33166 into 138d215 on jenkinsci:master.

@rantoniuk rantoniuk merged commit 4e6793f into jenkinsci:master Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants