Remove all deprecated fields and classes for 4.0 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 855
💛 - Coveralls |
rantoniuk
commented
Apr 4, 2020
|
@olamy, @artkoshelev PTAL |
artkoshelev
reviewed
Apr 6, 2020
| try { | ||
| session = site.getSession(); | ||
| session.getMyPermissions(); | ||
| return FormValidation.ok("Success"); | ||
| } catch (RestClientException e) { | ||
| } catch (RuntimeException e) { |
There was a problem hiding this comment.
that's significant change of method contract, seems not related to described changes
There was a problem hiding this comment.
This change was done to cover the frequent NPE case and to log it accordingly instead of throwing it as this method is supposed to return FormValidation error, so for me the contract stays the same.
|
Kudos, SonarCloud Quality Gate passed!
|
rantoniuk
force-pushed
the
remove-deprecations
branch
from
a4578c4
to
48fcb6d
Compare
rantoniuk
force-pushed
the
remove-deprecations
branch
from
48fcb6d
to
c9588d2
Compare
artkoshelev
approved these changes
Apr 8, 2020
|
@olamy any thoughts or things you are not happy about? 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.