Fix getting dependent issues #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low to update JIRA issues based on jobs associated with changes. Other changes: 1. Refactor selectors. Break down methods in DefaultIssuesSelector so that it is easier to reuse. Side effect is that DefaultIssueSelector now will be fully recursive (once the other problems are fixed). 2. Fix resources (DefaultUpdaterIssueSelector/config.jelly->selectors/DefaultIssueSelector/config.jelly).
It probably would be better if it used IssueSelector of dependent build rather than applying Selector from current build.
|
I am planning on adding a test case. |
| @@ -128,7 +128,7 @@ protected void addIssuesFromCurrentBuild(Run<?, ?> build, JiraSite site, TaskLis | |||
| */ | |||
| protected void addIssuesFromDependentBuilds(Run<?, ?> build, JiraSite site, TaskListener listener, | |||
| Set<String> issueIds) { | |||
| for (DependencyChange depc : RunScmChangeExtractor.getDependencyChanges(build.getPreviousBuild()).values()) { | |||
| for (DependencyChange depc : RunScmChangeExtractor.getDependencyChanges(build).values()) { | |||
There was a problem hiding this comment.
I don't understand this change.. For me this is exactly as it was before, but previousBuild extraction is moved to RunScmChangeExtractor. Did you get NPE on the previous code in this line?
There was a problem hiding this comment.
Previously it was getting dependency changes between previous build and ... previous build.
Now it is taking dependency changes between current and previous build.
rantoniuk
added a commit
that referenced
this pull request
May 3, 2016
* upstream/pr/97: Fix dependent builds handling. It probably would be better if it used IssueSelector of dependent build rather than applying Selector from current build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated on the plugin Wiki: "By taking advantages of Jenkins' fingerprint feature, when your other projects that depend on this project pick up a build with a fix, those build numbers can also be recorded in JIRA".
Selecting dependent issues currently does not work. This pull request is to fix it.
This change depends on #95
This change is