Diagnosis/recovery for infinite loop in AbstractTestResultAction.buildDataSet

[jglick]

A Jenkins instance running 1.554.3 was observed to crash in a thread running

Handling GET /job/…/test/trend : …
  at java.lang.OutOfMemoryError.<init>()V (Unknown Source)
  at java.util.Arrays.copyOf([Ljava/lang/Object;I)[Ljava/lang/Object; (Unknown Source)
  at java.util.ArrayList.grow(I)V (Unknown Source)
  at java.util.ArrayList.ensureCapacityInternal(I)V (Unknown Source)
  at java.util.ArrayList.add(Ljava/lang/Object;)Z (Unknown Source)
  at hudson.util.DataSetBuilder.add(Ljava/lang/Number;Ljava/lang/Comparable;Ljava/lang/Comparable;)V (DataSetBuilder.java:52)
  at hudson.tasks.test.AbstractTestResultAction.buildDataSet(Lorg/kohsuke/stapler/StaplerRequest;)Lorg/jfree/data/category/CategoryDataset; (AbstractTestResultAction.java:260)
  at hudson.tasks.test.AbstractTestResultAction.doGraph(Lorg/kohsuke/stapler/StaplerRequest;Lorg/kohsuke/stapler/StaplerResponse;)V (AbstractTestResultAction.java:221)
  at hudson.tasks.test.TestResultProjectAction.doTrend(Lorg/kohsuke/stapler/StaplerRequest;Lorg/kohsuke/stapler/StaplerResponse;)V (TestResultProjectAction.java:97)
  at …

where (according to Eclipse Memory Analyzer) the DataSetBuilder had accumulated hundreds of megabytes of objects. I hypothesize that this loop fails to terminate. This patch tries to detect (and recover from) the most plausible proximate cause, that an action is attached simultaneously to two builds.

@reviewbybees (ref. ZD-24012)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[jtnord]

👍

[kutzi]

There might have been a similar issue in https://issues.jenkins-ci.org/browse/JENKINS-31660 (infinite loop in TestResult.getPreviousResult) which has not been fixed by this.
Maybe you have some ideas, what might be going on there