Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-22747] Add Job Configuration Option to NOT fail JUnit Report publish when no test result files #30

Closed
wants to merge 6 commits into from

Conversation

jplandolt
Copy link

Fix for JENKINS-22747. Allows the for each job to be configured so as to allow zero JUnit Result files. This is for projects that do not yet have any unit test results.

The default is false; jobs with zero JUnit Result files will fail the job. This is the current default behaviour of the plugin (as it should be)

mistake - did not require this
…zero JUnit test reports generated

Added field to track this
Added logic around the condition
@jplandolt jplandolt closed this Oct 20, 2015
@jplandolt jplandolt deleted the JENKINS-22747 branch October 20, 2015 17:23
@jplandolt jplandolt restored the JENKINS-22747 branch October 20, 2015 18:50
@jplandolt jplandolt reopened this Oct 20, 2015
@jplandolt
Copy link
Author

Oops!!

@jplandolt jplandolt changed the title Jenkins 22747 [JENKINS-22747] Add Job Configuration Option to NOT fail JUnit Report publish when no test result files Oct 20, 2015
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


/**
* @set the ignoreNoReports
* @since 1.596.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the plugin's version. May be confusing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the version number be used here, please?

@oleg-nenashev
Copy link
Member

👍 for the contents.
I'm not sure about the impact of permission changes

@per-bohlin
Copy link

More or less same solution has been offered in pull-request #28, with the difference that the option is placed in "advanced" section and it provide unit tests to prove the functionality.

@jplandolt
Copy link
Author

Ok good to know! I'm happy to drop this request as soon as pull-request #28 is accepted.

@christ66
Copy link
Member

#28 has been accepted, so I will mark as closed. Thank you @jplandolt for working on this!

@christ66 christ66 closed this Nov 25, 2015
@jplandolt jplandolt deleted the JENKINS-22747 branch December 10, 2015 21:26
@jplandolt
Copy link
Author

And it's closed and the branch is in the wind. thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants