Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71139] Alternate reproducer for NUL issue in SuiteResult.stdout #520

Merged
merged 1 commit into from Apr 24, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 24, 2023

jenkinsci/jenkins#7875 but demonstrating how this can break JUnit test results when a test happens to print NUL characters in its standard output, depending on exactly how the report is structured. Passes against Jenkins 2.397, fails against 2.398—though, weirdly, in a different way than both the observed file load error and the core test failure: rather than the parsing failing with an error message, the stdout field is simply quietly omitted (left null).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ od -a src/test/resources/hudson/tasks/junit/null-output.txt
0000000   f   o   o nul   b   a   r
0000007

@timja timja added the test A PR that adds to testing - used by Release Drafter label Apr 24, 2023
@timja timja merged commit fe62d9e into jenkinsci:master Apr 24, 2023
13 checks passed
@jglick jglick deleted the xml-JENKINS-71139 branch April 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A PR that adds to testing - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants