Do not consider a build with unloadable TestResult
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Apr 22, 2023
| TestResult tr = (TestResult) o; | ||
| String hyperlink = ModelHyperlinkNote.encodeTo('/' + b.getUrl(), originProject != b.getParent() ? b.getFullDisplayName() : b.getDisplayName()); | ||
| if (tr.getTotalCount() == 0) { | ||
| listener.getLogger().printf("Build %s has no loadable test results (supposed count %d), skipping%n", tra.getTotalCount(), hyperlink); |
There was a problem hiding this comment.
Note persisted Integer totalCount, as opposed to actually loading the results and counting.
(cherry picked from commit 93afed3)
|
#248 works as a hotfix. Ought to add a test case. |
|
(motivation: jenkinsci/jenkins#7875 / jenkinsci/junit-plugin#520) |
…xecutor-plugin into unloadable-results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
junitReport.xmlis malformed, https://github.com/jenkinsci/junit-plugin/blob/b4cf28bc7724c49bc93560c7bf95acdca4bbde1b/src/main/java/hudson/tasks/junit/TestResultAction.java#L227-L240 can causeParallelTestExecutor.getTestResultto nonetheless consider that build a valid baseline, but with zero results which of course causes split calculation to not work sanely. Ignore such builds, and continue searching for better ones, or at worst fall back to source scanning.