Fixes #687 - Enable customization of master Jenkins service account via default Helm template #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sig00rd
approved these changes
Dec 20, 2021
|
Hi @Sig00rd, what do I neeed to do in order to fix these tests? Is it valid that they are failing? |
SylwiaBrant
approved these changes
Dec 21, 2021
|
Please, pull in the changes from the master, so the tests can pass :) |
|
Hi @SylwiaBrant I did that, hopefully the tests will now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to be able to provide the annotations attached to the
service account associated with the Jenkins master instance.
Changes
I have made the small changes necessary in order to enable adapting the
ServiceAccountused by the master Jenkins which is provisioned with the default Helm chart.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.