Attempts to fetch workspace from Master if all slaves are offline #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iocanel
requested changes
Feb 23, 2017
| LOGGER.info("Workspace exists ? " + workspace.exists()); | ||
| if (workspace.exists()) { | ||
| return new FilePath(workspace); | ||
| if(job != null) { |
There was a problem hiding this comment.
There is no need to add a null check before an instanceof.
http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.20.2
There was a problem hiding this comment.
This makes sense. I'll change it.
There was a problem hiding this comment.
Where should I add the comment about this in readme? I am not sure about the proper location; I was thinking at the end of the file with header 'Workspace support from Master' and details in the body?
carlossg
requested changes
Feb 27, 2017
| LOGGER.info("Nodes went offline. Hence fetching it through master"); | ||
| if (job instanceof AbstractProject) { | ||
| String assignedLabel = ((AbstractProject) job).getAssignedLabelString(); | ||
| KubernetesCloud kubernetesCloud = Hudson.getInstance().clouds.get(KubernetesCloud.class); |
There was a problem hiding this comment.
You can have multiple KubernetesClouds, each with a different id
| String workspacePath = filePath.toString(); | ||
| LOGGER.info("Workspace Path: " + workspacePath); | ||
| File workspace = new File(workspacePath); | ||
| LOGGER.info("Workspace exists ? " + workspace.exists()); |
There was a problem hiding this comment.
These logging statements should be level FINE
|
Closing this PR as I messed up part of the code. Will create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.