Fixed: JENKINS-40925 - dir context is not honored by shell step #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not familiar with dir context, but the code looks good and tests seem to pass. |
|
@carlossg can you have a look please? |
carlossg
reviewed
Mar 8, 2017
| @@ -72,7 +70,6 @@ public ContainerExecDecorator(KubernetesClient client, String podName, String co | |||
| this.client = client; | |||
| this.podName = podName; | |||
| this.containerName = containerName; | |||
| this.path = path; | |||
There was a problem hiding this comment.
if path is removed, then the constructor should be deprecated and a new one without path argument added
There was a problem hiding this comment.
@carlossg there is only one usage of this constructor, so I can just change the signature inplace.
Do I still need to deprecate and create new one?
There was a problem hiding this comment.
I've removed unused parameter
There was a problem hiding this comment.
yes, better to copy and deprecate to keep backwards binary compatibility
There was a problem hiding this comment.
@carlossg green light
rawlingsj
pushed a commit
to fabric8io/kubernetes-plugin
that referenced
this pull request
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks too easy.
Please let me know if there is a reason not to use command's pwd.