New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support idleMinutes field in pipeline #154

Merged
merged 3 commits into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@zoumo

zoumo commented Apr 11, 2017

No description provided.

@zoumo

This comment has been minimized.

Show comment
Hide comment
@zoumo

zoumo Apr 11, 2017

Can someone tell me what's wrong with my PR?

zoumo commented Apr 11, 2017

Can someone tell me what's wrong with my PR?

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Apr 11, 2017

it's in the linked jenkins report at https://jenkins.ci.cloudbees.com/job/plugins/job/kubernetes-plugin/542/console

[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Self assignment of field PodTemplateStep.idleMinutes in org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStep.setIdleMinutes(int) [org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStep] At PodTemplateStep.java:[line 133] SA_FIELD_SELF_ASSIGNMENT

carlossg commented Apr 11, 2017

it's in the linked jenkins report at https://jenkins.ci.cloudbees.com/job/plugins/job/kubernetes-plugin/542/console

[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Self assignment of field PodTemplateStep.idleMinutes in org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStep.setIdleMinutes(int) [org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStep] At PodTemplateStep.java:[line 133] SA_FIELD_SELF_ASSIGNMENT
Show outdated Hide outdated ...va/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep.java
@DataBoundSetter
public void setIdleMinutes(int instanceCap) {
this.idleMinutes = idleMinutes;

This comment has been minimized.

@iocanel

iocanel Apr 11, 2017

@zoumo: This is why the build fails. I guess you need to change the method argument to idleMinutes.

@iocanel

iocanel Apr 11, 2017

@zoumo: This is why the build fails. I guess you need to change the method argument to idleMinutes.

This comment has been minimized.

@zoumo

zoumo Apr 11, 2017

thank you.

@zoumo

This comment has been minimized.

Show comment
Hide comment

zoumo commented Apr 24, 2017

got it

@carlossg

waiting for the docs

@zoumo

This comment has been minimized.

Show comment
Hide comment
@zoumo

zoumo May 12, 2017

@carlossg @iocanel help doc is ok now

zoumo commented May 12, 2017

@carlossg @iocanel help doc is ok now

@carlossg carlossg merged commit d98c332 into jenkinsci:master Jun 1, 2017

1 check passed

Jenkins This pull request looks good
Details
@carlossg

This comment has been minimized.

Show comment
Hide comment

carlossg commented Jun 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment